refactor 166

fishercoder1534 · fishercoder1534 · commit 3696a2b77924 · 2018-05-25T07:28:57.000-07:00
diff --git a/src/main/java/com/fishercoder/solutions/_166.java b/src/main/java/com/fishercoder/solutions/_166.java
@@ -18,39 +18,41 @@
 
  */
 public class _166 {
-    /**credit: https://discuss.leetcode.com/topic/33311/simple-and-short-solution-in-java*/
+  public static class Solution1 {
+    /** credit: https://discuss.leetcode.com/topic/33311/simple-and-short-solution-in-java */
     public String fractionToDecimal(int numerator, int denominator) {
-        String sign = (numerator >= 0 && denominator >= 0) || (numerator < 0 && denominator < 0) ? "" : "-";
-        if (numerator == 0) {
-            return "0";
-        }
-        long num = Math.abs((long) numerator);
-        long deno = Math.abs((long) denominator);
-        StringBuilder stringBuilder = new StringBuilder();
-        stringBuilder.append(sign);
-        long integral = Math.abs(num / deno);
-        stringBuilder.append(integral);
-        if (numerator % denominator == 0) {
-            return stringBuilder.toString();
-        } else {
-            stringBuilder.append(".");
-        }
-        long remainder = num % deno;
-
-        Map<Long, Integer> map = new HashMap<>();
-        while (!map.containsKey(remainder)) {
-            map.put(remainder, stringBuilder.length());
-            long n = remainder * 10 / deno;
-            remainder = remainder * 10 % deno;
-            if (remainder != 0 || (remainder == 0 && !map.containsKey(remainder))) {
-                stringBuilder.append(n);
-            }
-        }
-        if (remainder != 0) {
-            stringBuilder.insert(map.get(remainder), "(");
-            stringBuilder.append(")");
-        }
+      String sign =
+          (numerator >= 0 && denominator >= 0) || (numerator < 0 && denominator < 0) ? "" : "-";
+      if (numerator == 0) {
+        return "0";
+      }
+      long num = Math.abs((long) numerator);
+      long deno = Math.abs((long) denominator);
+      StringBuilder stringBuilder = new StringBuilder();
+      stringBuilder.append(sign);
+      long integral = Math.abs(num / deno);
+      stringBuilder.append(integral);
+      if (numerator % denominator == 0) {
         return stringBuilder.toString();
+      } else {
+        stringBuilder.append(".");
+      }
+      long remainder = num % deno;
+
+      Map<Long, Integer> map = new HashMap<>();
+      while (!map.containsKey(remainder)) {
+        map.put(remainder, stringBuilder.length());
+        long n = remainder * 10 / deno;
+        remainder = remainder * 10 % deno;
+        if (remainder != 0 || (remainder == 0 && !map.containsKey(remainder))) {
+          stringBuilder.append(n);
+        }
+      }
+      if (remainder != 0) {
+        stringBuilder.insert(map.get(remainder), "(");
+        stringBuilder.append(")");
+      }
+      return stringBuilder.toString();
     }
-
+  }
 }
diff --git a/src/test/java/com/fishercoder/_166Test.java b/src/test/java/com/fishercoder/_166Test.java
@@ -6,54 +6,51 @@
 
 import static org.junit.Assert.assertEquals;
 
-/**
- * Created by fishercoder on 5/28/17.
- */
 public class _166Test {
-    private static _166 test;
-
-    @BeforeClass
-    public static void setup() {
-        test = new _166();
-    }
-
-    @Test
-    public void test1() {
-        assertEquals("0.5", test.fractionToDecimal(1, 2));
-    }
-
-    @Test
-    public void test2() {
-        assertEquals("2", test.fractionToDecimal(2, 1));
-    }
-
-    @Test
-    public void test3() {
-        assertEquals("0.(6)", test.fractionToDecimal(2, 3));
-    }
-
-    @Test
-    public void test4() {
-        assertEquals("-6.25", test.fractionToDecimal(-50, 8));
-    }
-
-    @Test
-    public void test5() {
-        assertEquals("-0.58(3)", test.fractionToDecimal(7, -12));
-    }
-
-    @Test
-    public void test6() {
-        assertEquals("0.0000000004656612873077392578125", test.fractionToDecimal(-1, -2147483648));
-    }
-
-    @Test
-    public void test7() {
-        assertEquals("0", test.fractionToDecimal(0, -5));
-    }
-
-    @Test
-    public void test8() {
-        assertEquals("-2147483648", test.fractionToDecimal(-2147483648, 1));
-    }
+  private static _166.Solution1 solution1;
+
+  @BeforeClass
+  public static void setup() {
+    solution1 = new _166.Solution1();
+  }
+
+  @Test
+  public void test1() {
+    assertEquals("0.5", solution1.fractionToDecimal(1, 2));
+  }
+
+  @Test
+  public void test2() {
+    assertEquals("2", solution1.fractionToDecimal(2, 1));
+  }
+
+  @Test
+  public void test3() {
+    assertEquals("0.(6)", solution1.fractionToDecimal(2, 3));
+  }
+
+  @Test
+  public void test4() {
+    assertEquals("-6.25", solution1.fractionToDecimal(-50, 8));
+  }
+
+  @Test
+  public void test5() {
+    assertEquals("-0.58(3)", solution1.fractionToDecimal(7, -12));
+  }
+
+  @Test
+  public void test6() {
+    assertEquals("0.0000000004656612873077392578125", solution1.fractionToDecimal(-1, -2147483648));
+  }
+
+  @Test
+  public void test7() {
+    assertEquals("0", solution1.fractionToDecimal(0, -5));
+  }
+
+  @Test
+  public void test8() {
+    assertEquals("-2147483648", solution1.fractionToDecimal(-2147483648, 1));
+  }
 }
