Skip to content

chore: Enable Fabric #6478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 322 commits into
base: develop
Choose a base branch
from
Draft

chore: Enable Fabric #6478

wants to merge 322 commits into from
+856 −459

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Jul 3, 2025 •
edited
Loading

Proposed changes

Now Fabric is enabled, pay attention to batch updates https://react.dev/learn/queueing-a-series-of-state-updates

Issue(s)

Depends on #6380
Depends on RocketChat/react-native-simple-crypto#8
Depends on #6502

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello
Merge branch 'develop' into chore.tab-view-emoji
751f682
@diegolmello
Merge branch 'develop' into chore.tab-view-emoji
800f5fc
@diegolmello
Fix e2e tests
e17d1b2
@diegolmello
kinda building iOS
86cca81
@diegolmello
temp fix header buttons
8c652f6
@diegolmello
pods
68596f8
@diegolmello
Android is kinda building
8e464f4
@diegolmello
Patch software-mansion/react-native-screens#2219
3aaa9eb
@diegolmello
iOS building once again
c997cc8
@diegolmello
Revert "Patch software-mansion/react-native-screens#2219"
428daa3 
This reverts commit f90e17b.
@diegolmello
Fix pods on old arch
1e2c783
@diegolmello
Cleanup podfile
cb895e4
@diegolmello
Temp fix lint/ts
e871e2a
@diegolmello
temp remove unit tests on ci
ba0d007
@diegolmello
pod old arch on CI
2060d0b
@diegolmello
Added firebase
b0886cf
@diegolmello
Bitcode is still an issue. Fixed on Podfile again.
10acb8f
@diegolmello
Remove Reactotron
f7c7597
@diegolmello
BackHandler fixes
0d881dc
@diegolmello
Fix Android source maps upload
38d8420
@diegolmello
Fix push on Android
b0fa1f9
@diegolmello
Fix lint
f7358aa
@diegolmello
Expo-asset is required for videoconf
c4ebe8f
@diegolmello
Update testing setup and dependencies: mock expo-font in jest setup, …
0d28126 
…upgrade @testing-library/react-native to 13.2.0, and update jest-expo to 52.0.6. Refactor useEndpointData tests to use render from @testing-library/react-native.
@diegolmello
chore: update Babel configuration to use babel-preset-expo
9025d51
@diegolmello
test: refactor MessageComposer tests
8cbf49f
@diegolmello
test: update ReactionsList and useEndpointData tests
e623253
@diegolmello
test: enable testing in CircleCI configuration
182ffbb
@diegolmello
https://reactnative.dev/blog/2025/01/21/version-0.77#rctappdependency…
6291491 
…provider
@diegolmello
Fix lint and pods
5e1f735
@diegolmello diegolmello mentioned this pull request Jul 29, 2025
Closed
@diegolmello diegolmello had a problem deploying to experimental_android_build July 31, 2025 14:03 — with GitHub Actions Error
@diegolmello diegolmello had a problem deploying to experimental_ios_build July 31, 2025 14:03 — with GitHub Actions Error
@diegolmello diegolmello had a problem deploying to official_android_build July 31, 2025 14:03 — with GitHub Actions Error
@diegolmello diegolmello had a problem deploying to experimental_android_build July 31, 2025 18:22 — with GitHub Actions Error
@diegolmello diegolmello had a problem deploying to experimental_ios_build July 31, 2025 18:22 — with GitHub Actions Error
@diegolmello diegolmello had a problem deploying to official_android_build July 31, 2025 18:22 — with GitHub Actions Error
@diegolmello
Copy link
Member Author

diegolmello commented Jul 31, 2025 •
edited
Loading

Fabric doesn't fix inline images :(

@Rohit3523
Copy link
Collaborator

Rohit3523 commented Jul 31, 2025 •
edited
Loading

I think it's not React Native issue, we should check the styling and code for it 🫣

@diegolmello
Copy link
Member Author

@Rohit3523 Are you sure? #6239 (comment)

@Rohit3523
Copy link
Collaborator

😬😬

@diegolmello diegolmello mentioned this pull request Jul 31, 2025
Open
@diegolmello diegolmello requested a deployment to official_android_build August 1, 2025 19:42 — with GitHub Actions Waiting
@diegolmello diegolmello requested a deployment to experimental_ios_build August 1, 2025 19:42 — with GitHub Actions Waiting
@diegolmello diegolmello requested a deployment to experimental_android_build August 1, 2025 19:42 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegolmello @Rohit3523
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy