Skip to content

Refactored CLI to be a separate package #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2020

Conversation

garrettluu
Copy link
Contributor

Moved the CLI to another package codepage-cli.

The source code for the CLI has been moved to packages/codepage-cli, and is called when the user executes the cli.js script.

@coveralls
Copy link

coveralls commented Jun 18, 2020

Coverage Status

Coverage remained the same at 97.494% when pulling 48cbd10 on garrettluu:master into 62fd61e on SheetJS:master.

Copy link
Contributor

@SheetJSDev SheetJSDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with @srijonsaha the "scripts" section should be removed

* Moved cli to packages folder

* Removed bin

* Renamed cli folder

* Fixed cli issues

* Fixed dependency issues

* Fixed duplicate script and cli name

* Removed cli.js

* Moved run function to index.js

* Added author and removed fs dependency

* Removed cli dependencies

* Removed scripts
@garrettluu garrettluu merged commit ff3c114 into SheetJS:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy