BT-Fix: Buffer load in BT

Alexander Blair · Alexander Blair · commit 91b22c4def4e · 2019-11-23T16:17:57.000-08:00
diff --git a/lib/xmr.js b/lib/xmr.js
@@ -55,7 +55,7 @@ function BlockTemplate(template) {
   this.previousHash = new Buffer(32);
   this.workerNonce = 0;
   this.solo = false;
-  this.seedHash = template.seed_hash;
+  this.seedHash = template.seed_hash ? Buffer.from(template.seed_hash, 'hex') : Buffer.from('00', 'hex');
   if (typeof (this.workerOffset) === 'undefined') {
     this.solo = true;
     global.instanceId.copy(this.buffer, this.reservedOffset + 4, 0, 3);
@@ -92,7 +92,7 @@ function MasterBlockTemplate(template) {
   this.workerNonce = 0;
   this.poolNonce = 0;
   this.solo = false;
-  this.seedHash = template.seed_hash;
+  this.seedHash = template.seed_hash ? Buffer.from(template.seed_hash, 'hex') : Buffer.from('00', 'hex');
   if (typeof (this.workerOffset) === 'undefined') {
     this.solo = true;
     global.instanceId.copy(this.buffer, this.reservedOffset + 4, 0, 3);
@@ -197,10 +197,11 @@ function processShare(miner, job, blockTemplate, nonce, resultHash) {
     // Validate share with CN hash, then if valid, blast it up to the master.
     let shareBuffer = cnUtil.construct_block_blob(template, new Buffer(nonce, 'hex'));
     let convertedBlob = cnUtil.convert_blob(shareBuffer);
-    if (blockTemplate.seedHash == null || blockTemplate.seedHash === Buffer.from('00', 'hex')) {
+    let nulbuf = Buffer.from('00', 'hex');
+    if (blockTemplate.seedHash == null || blockTemplate.seedHash === nulbuf) {
       hash = multiHashing.cryptonight(convertedBlob, convertedBlob[0] >= 10 ? 13 : 8, job.height);
     } else {
-      hash = multiHashing.randomx(convertedBlob, Buffer.from(blockTemplate.seedHash, 'hex'), 0);
+      hash = multiHashing.randomx(convertedBlob, blockTemplate.seedHash, 0);
     }
     if (hash.toString("hex") !== resultHash) {
       if (multiHashing.cryptonight(convertedBlob, 0).toString("hex") === resultHash) {
