Optimized slugger: trimming dash at the beginning & end and removed double dashes

Sebastian Blum · Sebastian Blum · commit 5c82409e2390 · 2015-03-28T19:05:44.000+01:00
diff --git a/src/AppBundle/Tests/Utils/SluggerTest.php b/src/AppBundle/Tests/Utils/SluggerTest.php
@@ -42,7 +42,9 @@ public function getSlugs()
         return array(
             array('Lorem Ipsum'     , 'lorem-ipsum'),
             array('  Lorem Ipsum  ' , 'lorem-ipsum'),
-            array(' lOrEm  iPsUm  ' , 'lorem--ipsum'),
+            array(' lOrEm  iPsUm  ' , 'lorem-ipsum'),
+            array('!Lorem Ipsum!'   , 'lorem-ipsum'),
+            array('lorem-ipsum'     , 'lorem-ipsum'),
         );
     }
 }
diff --git a/src/AppBundle/Utils/Slugger.php b/src/AppBundle/Utils/Slugger.php
@@ -22,6 +22,6 @@ class Slugger
 {
     public function slugify($string)
     {
-        return preg_replace('/[^a-z0-9]/', '-', strtolower(trim(strip_tags($string))));
+        return trim(preg_replace('/[^a-z0-9]+/', '-', strtolower(trim(strip_tags($string)))), '-');
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,9 @@ public function getSlugs()`
`42`	`42`	`return array(`
`43`	`43`	`array('Lorem Ipsum' , 'lorem-ipsum'),`
`44`	`44`	`array(' Lorem Ipsum ' , 'lorem-ipsum'),`
`45`		`- array(' lOrEm iPsUm ' , 'lorem--ipsum'),`
	`45`	`+ array(' lOrEm iPsUm ' , 'lorem-ipsum'),`
	`46`	`+ array('!Lorem Ipsum!' , 'lorem-ipsum'),`
	`47`	`+ array('lorem-ipsum' , 'lorem-ipsum'),`
`46`	`48`	`);`
`47`	`49`	`}`
`48`	`50`	`}`
Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,6 @@ class Slugger`
`22`	`22`	`{`
`23`	`23`	`public function slugify($string)`
`24`	`24`	`{`
`25`		`- return preg_replace('/[^a-z0-9]/', '-', strtolower(trim(strip_tags($string))));`
	`25`	`+ return trim(preg_replace('/[^a-z0-9]+/', '-', strtolower(trim(strip_tags($string)))), '-');`
`26`	`26`	`}`
`27`	`27`	`}`