minor symfony#64 Fixed the help notes of the AddUser command (javiereguiluz)

javiereguiluz · javiereguiluz · commit 61b2835c6459 · 2015-04-30T08:39:35.000+02:00
This PR was squashed before being merged into the master branch (closes symfony#64). Discussion ---------- Fixed the help notes of the AddUser command In the [run() method of the Command class](https://github.com/symfony/symfony/blob/2.7/src/Symfony/Component/Console/Command/Command.php#L220-263) you can see the following: ```php public function run(InputInterface $input, OutputInterface $output) { // ... $this->initialize($input, $output); // ... if ($input->isInteractive()) { $this->interact($input, $output); } // ... $statusCode = $this->execute($input, $output); return is_numeric($statusCode) ? (int) $statusCode : 0; } ``` Therefore, our help note was wrong and the method order is ` initialize()` -> `interact()` -> `execute()` Commits ------- 7afdf50 Fixed the help notes of the AddUser command
diff --git a/src/AppBundle/Command/AddUserCommand.php b/src/AppBundle/Command/AddUserCommand.php
@@ -61,8 +61,21 @@ protected function configure()
     }
 
     /**
-     * This method is executed before initialize() and execute(). Its purpose is
-     * to check if some of the options/arguments are missing and interactively
+     * This method is executed before the interact() and the execute() methods.
+     * It's main purpose is to initialize the variables used in the rest of the
+     * command methods.
+     *
+     * Beware that the input options and arguments are validated after executing
+     * the interact() method, so you can't blindly trust their values in this method.
+     */
+    protected function initialize(InputInterface $input, OutputInterface $output)
+    {
+        $this->em = $this->getContainer()->get('doctrine')->getManager();
+    }
+
+    /**
+     * This method is executed after initialize() and before execute(). Its purpose
+     * is to check if some of the options/arguments are missing and interactively
      * ask the user for those values.
      *
      * This method is completely optional. If you are developing an internal console
@@ -147,16 +160,6 @@ protected function interact(InputInterface $input, OutputInterface $output)
         }
     }
 
-    /**
-     * This method is executed before the interact() and the execute() methods.
-     * It's main purpose is to initialize the variables used in the rest of the
-     * command methods.
-     */
-    protected function initialize(InputInterface $input, OutputInterface $output)
-    {
-        $this->em = $this->getContainer()->get('doctrine')->getManager();
-    }
-
     /**
      * This method is executed after interact() and initialize(). It usually
      * contains the logic to execute to complete this command task.
