bug symfony#25 Use DIRECTORY_SEPARATOR constant to avoid Windows issues (javiereguiluz)

javiereguiluz · javiereguiluz · commit d3f456dca93f · 2015-04-07T15:12:46.000+02:00
This PR was squashed before being merged into the master branch (closes symfony#25). Discussion ---------- Use DIRECTORY_SEPARATOR constant to avoid Windows issues This PR fixes the issue reported at symfony#14239 Commits ------- 622a9d0 Use DIRECTORY_SEPARATOR constant to avoid Windows issues
diff --git a/src/AppBundle/Twig/SourceCodeExtension.php b/src/AppBundle/Twig/SourceCodeExtension.php
@@ -82,8 +82,8 @@ private function getControllerRelativePath()
         $class = new \ReflectionClass($className);
 
         $absolutePath = $class->getFilename();
-        $pathParts = explode('/src/', $absolutePath);
-        $relativePath = 'src/'.$pathParts[1];
+        $pathParts = explode(DIRECTORY_SEPARATOR.'src'.DIRECTORY_SEPARATOR, $absolutePath);
+        $relativePath = 'src'.DIRECTORY_SEPARATOR.$pathParts[1];
 
         return $relativePath;
     }

Original file line number	Diff line number	Diff line change
`@@ -82,8 +82,8 @@ private function getControllerRelativePath()`
`82`	`82`	`$class = new \ReflectionClass($className);`
`83`	`83`
`84`	`84`	`$absolutePath = $class->getFilename();`
`85`		`- $pathParts = explode('/src/', $absolutePath);`
`86`		`- $relativePath = 'src/'.$pathParts[1];`
	`85`	`+ $pathParts = explode(DIRECTORY_SEPARATOR.'src'.DIRECTORY_SEPARATOR, $absolutePath);`
	`86`	`+ $relativePath = 'src'.DIRECTORY_SEPARATOR.$pathParts[1];`
`87`	`87`
`88`	`88`	`return $relativePath;`
`89`	`89`	`}`