minor symfony#28 Added a method to unindent the source code of the controller (javiereguiluz)

javiereguiluz · javiereguiluz · commit db75f6cae226 · 2015-04-08T09:03:57.000+02:00
This PR was merged into the master branch. Discussion ---------- Added a method to unindent the source code of the controller ### Before ![before](https://cloud.githubusercontent.com/assets/73419/7025029/0e3b2a5a-dd41-11e4-8bba-3e846a7b1a48.png) ### After ![after](https://cloud.githubusercontent.com/assets/73419/7025030/0f442c4e-dd41-11e4-8d66-278dd2915751.png) Commits ------- 6378584 Added a method to unindent the source code of the controller
diff --git a/src/AppBundle/Twig/SourceCodeExtension.php b/src/AppBundle/Twig/SourceCodeExtension.php
@@ -66,9 +66,11 @@ private function getControllerCode()
         $class = new \ReflectionClass($className);
         $method = $class->getMethod($this->controller[1]);
 
-        $code = file($class->getFilename());
+        $classCode = file($class->getFilename());
+        $methodCode = array_slice($classCode, $method->getStartline() - 1, $method->getEndLine() - $method->getStartline() + 1);
+        $controllerCode = '    '.$method->getDocComment()."\n".implode('', $methodCode);
 
-        return '    '.$method->getDocComment()."\n".implode('', array_slice($code, $method->getStartline() - 1, $method->getEndLine() - $method->getStartline() + 1));
+        return $this->unindentCode($controllerCode);
     }
 
     private function getControllerRelativePath()
@@ -106,6 +108,32 @@ private function getTemplateRelativePath()
         return 'app/Resources/views/'.$this->template->getTemplateName();
     }
 
+    /**
+     * Utility method that "unindents" the given $code when all its lines start
+     * with a tabulation of four white spaces.
+     *
+     * @param  string $code
+     * @return string
+     */
+    private function unindentCode($code)
+    {
+        $formattedCode = '';
+        $codeLines = explode("\n", $code);
+
+        $indentedLines = array_filter($codeLines, function ($lineOfCode) {
+            return '' === $lineOfCode || '    ' === substr($lineOfCode, 0, 4);
+        });
+
+        if (count($indentedLines) === count($codeLines)) {
+            $formattedCode = array_map(function ($lineOfCode) { return substr($lineOfCode, 4); }, $codeLines);
+            $formattedCode = implode("\n", $formattedCode);
+        } else {
+            $formattedCode = $code;
+        }
+
+        return $formattedCode;
+    }
+
     // the name of the Twig extension must be unique in the application
     public function getName()
     {
