[TASK] Assert result based on symfony version in deprecated code tests

sbuerk · sbuerk · commit 81de9ac1b3bb · 2024-01-06T13:08:38.000+01:00
Symfony 7 removed deprecated code paths [1][2] and therefore started using strict `in_array()` check for the `in` and `notIn` condition in the expression language. With #102746 the usage of symfony 7 has been allowed, which itself introduces breaking changes. It is optional to upgrade to symfony 7 and therefore breaking changes has been respected and excludes from the TYPO3 policies regarding breaking changes as it is not enforced. This change modifies two tests to assert results based on the used symfony version. [1] symfony/symfony#50867 [2] symfony/symfony@7050bc82dd25c540958 Resolves: #102766 Related: #102746 Releases: 12.4 Change-Id: I0624f33ff270ba793054d0ff84810beee1a98c06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82358 Reviewed-by: Stefan Bürk <stefan@buerk.tech> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de> Tested-by: Oliver Klee <typo3-coding@oliverklee.de> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by: core-ci <typo3@b13.com> Tested-by: Stefan Bürk <stefan@buerk.tech>
diff --git a/typo3/sysext/backend/Tests/FunctionalDeprecated/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php b/typo3/sysext/backend/Tests/FunctionalDeprecated/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php
@@ -230,9 +230,21 @@ public function treeLevelConditionDoesNotMatchFaultyValue(): void
     public function PIDupinRootlineConditionMatchesSinglePageIdInRootline(): void
     {
         $subject = $this->getConditionMatcher(3);
+
+        if (!$this->isSymfonySeven()) {
+            // Before Symfony 7+ everything was chaos.
+            self::assertTrue($subject->match('[2 in tree.rootLineParentIds]'));
+            self::assertTrue($subject->match('["2" in tree.rootLineParentIds]'));
+            self::assertTrue($subject->match('[\'2\' in tree.rootLineParentIds]'));
+            return;
+        }
+
+        // Symfony 7 removed deprecated code paths and therefore started using strict `in_array()` check for the
+        // `in` and `notIn` condition in the expression language. Basically this is a breaking change in regard
+        // for TYPO3 users, but as the use of symfony 7 is the choice for project it's reasonable to live with it.
         self::assertTrue($subject->match('[2 in tree.rootLineParentIds]'));
-        self::assertTrue($subject->match('["2" in tree.rootLineParentIds]'));
-        self::assertTrue($subject->match('[\'2\' in tree.rootLineParentIds]'));
+        self::assertFalse($subject->match('["2" in tree.rootLineParentIds]'));
+        self::assertFalse($subject->match('[\'2\' in tree.rootLineParentIds]'));
     }
 
     /**
@@ -440,4 +452,14 @@ protected function setUpWorkspaceAspect(int $workspaceId): void
     {
         GeneralUtility::makeInstance(Context::class)->setAspect('workspace', new WorkspaceAspect($workspaceId));
     }
+
+    private function isSymfonySeven(): bool
+    {
+        // Symfony 7 dropped the `inArray` method with 7.0.0 from the BinaryNode, so we can use it as a check here for
+        // the version and avoid to deal with composer version information here.
+        return method_exists(
+            \Symfony\Component\ExpressionLanguage\Node\BinaryNode::class,
+            'inArray'
+        ) === false;
+    }
 }
diff --git a/typo3/sysext/frontend/Tests/FunctionalDeprecated/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php b/typo3/sysext/frontend/Tests/FunctionalDeprecated/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php
@@ -270,9 +270,21 @@ public function treeLevelConditionDoesNotMatchFaultyValue(): void
     public function PIDupinRootlineConditionMatchesSinglePageIdInRootline(): void
     {
         $subject = $this->getConditionMatcher();
+
+        if (!$this->isSymfonySeven()) {
+            // Before Symfony 7+ everything was chaos.
+            self::assertTrue($subject->match('[2 in tree.rootLineParentIds]'));
+            self::assertTrue($subject->match('["2" in tree.rootLineParentIds]'));
+            self::assertTrue($subject->match('[\'2\' in tree.rootLineParentIds]'));
+            return;
+        }
+
+        // Symfony 7 removed deprecated code paths and therefore started using strict `in_array()` check for the
+        // `in` and `notIn` condition in the expression language. Basically this is a breaking change in regard
+        // for TYPO3 users, but as the use of symfony 7 is the choice for project it's reasonable to live with it.
         self::assertTrue($subject->match('[2 in tree.rootLineParentIds]'));
-        self::assertTrue($subject->match('["2" in tree.rootLineParentIds]'));
-        self::assertTrue($subject->match('[\'2\' in tree.rootLineParentIds]'));
+        self::assertFalse($subject->match('["2" in tree.rootLineParentIds]'));
+        self::assertFalse($subject->match('[\'2\' in tree.rootLineParentIds]'));
     }
 
     /**
@@ -623,4 +635,14 @@ protected function setupFrontendController(int $pageId): void
             2 => ['uid' => 3, 'pid' => 2],
         ];
     }
+
+    private function isSymfonySeven(): bool
+    {
+        // Symfony 7 dropped the `inArray` method with 7.0.0 from the BinaryNode, so we can use it as a check here for
+        // the version and avoid to deal with composer version information here.
+        return method_exists(
+            \Symfony\Component\ExpressionLanguage\Node\BinaryNode::class,
+            'inArray'
+        ) === false;
+    }
 }
