Rename isLocalUpdate to forceUpdate

ohakutsu · ohakutsu · commit 0813b6df956f · 2023-07-24T16:14:46.000+09:00
diff --git a/src/commands/pull.ts b/src/commands/pull.ts
@@ -14,9 +14,9 @@ export const pull = async (argv: string[]) => {
 
   const qiitaApi = await getQiitaApiInstance();
   const fileSystemRepo = await getFileSystemRepo();
-  const isLocalUpdate = args["--force"];
+  const forceUpdate = args["--force"];
 
-  await syncArticlesFromQiita({ fileSystemRepo, qiitaApi, isLocalUpdate });
+  await syncArticlesFromQiita({ fileSystemRepo, qiitaApi, forceUpdate });
   console.log("Sync local articles from Qiita");
   console.log("Successful!");
 };
diff --git a/src/lib/file-system-repo.test.ts b/src/lib/file-system-repo.test.ts
@@ -315,9 +315,9 @@ updated
 `;
     const subject = (
       beforeSync: boolean = false,
-      isLocalUpdate: boolean = false
+      forceUpdate: boolean = false
     ) => {
-      return instance.saveItem(item, beforeSync, isLocalUpdate);
+      return instance.saveItem(item, beforeSync, forceUpdate);
     };
 
     describe("when local article does not exist", () => {
@@ -378,7 +378,7 @@ updated
         });
       });
 
-      describe("when isLocalUpdate is true", () => {
+      describe("when forceUpdate is true", () => {
         it("saves item local and remote", () => {
           const mockFs = fs as jest.Mocked<typeof fs>;
           mockFs.readdir.mockResolvedValueOnce([localFilename] as any[]);
diff --git a/src/lib/file-system-repo.ts b/src/lib/file-system-repo.ts
@@ -264,7 +264,7 @@ export class FileSystemRepo {
   private async syncItem(
     item: Item,
     beforeSync: boolean = false,
-    isLocalUpdate: boolean = false
+    forceUpdate: boolean = false
   ) {
     const fileContent = FileContent.fromItem(item);
 
@@ -279,17 +279,17 @@ export class FileSystemRepo {
       true
     );
 
-    if (data === null || remoteFileContent?.equals(data) || isLocalUpdate) {
+    if (data === null || remoteFileContent?.equals(data) || forceUpdate) {
       await this.setItemData(fileContent, true);
       await this.setItemData(fileContent, false, basename);
     } else {
       await this.setItemData(fileContent, true);
     }
   }
 
-  async saveItems(items: Item[], isLocalUpdate: boolean = false) {
+  async saveItems(items: Item[], forceUpdate: boolean = false) {
     const promises = items.map(async (item) => {
-      await this.syncItem(item, false, isLocalUpdate);
+      await this.syncItem(item, false, forceUpdate);
     });
 
     await Promise.all(promises);
@@ -298,9 +298,9 @@ export class FileSystemRepo {
   async saveItem(
     item: Item,
     beforeSync: boolean = false,
-    isLocalUpdate: boolean = false
+    forceUpdate: boolean = false
   ) {
-    await this.syncItem(item, beforeSync, isLocalUpdate);
+    await this.syncItem(item, beforeSync, forceUpdate);
   }
 
   async loadItems(): Promise<QiitaItem[]> {
diff --git a/src/lib/sync-articles-from-qiita.ts b/src/lib/sync-articles-from-qiita.ts
@@ -5,11 +5,11 @@ import { config } from "./config";
 export const syncArticlesFromQiita = async ({
   fileSystemRepo,
   qiitaApi,
-  isLocalUpdate = false,
+  forceUpdate = false,
 }: {
   fileSystemRepo: FileSystemRepo;
   qiitaApi: QiitaApi;
-  isLocalUpdate?: boolean;
+  forceUpdate?: boolean;
 }) => {
   const per = 100;
   const userConfig = await config.getUserConfig();
@@ -22,6 +22,6 @@ export const syncArticlesFromQiita = async ({
     const result = userConfig.includePrivate
       ? items
       : items.filter((item) => !item.private);
-    await fileSystemRepo.saveItems(result, isLocalUpdate);
+    await fileSystemRepo.saveItems(result, forceUpdate);
   }
 };
