Add RecalculateCurveDirections node

TeodorVecerdi · TeodorVecerdi · commit a49da0727352 · 2022-01-13T17:07:38.000+02:00
diff --git a/UnityGeometryGraph/Assets/GeometryGraph/Editor/Graph/Nodes/Curve/RecalculateCurveDirectionsNode.cs b/UnityGeometryGraph/Assets/GeometryGraph/Editor/Graph/Nodes/Curve/RecalculateCurveDirectionsNode.cs
@@ -0,0 +1,97 @@
+﻿using GeometryGraph.Runtime.Graph;
+using Newtonsoft.Json.Linq;
+using UnityEditor.Experimental.GraphView;
+using UnityEngine.UIElements;
+
+namespace GeometryGraph.Editor {
+    [Title("Curve", "Recalculate Directions")]
+    public class RecalculateCurveDirectionsNode : AbstractNode<GeometryGraph.Runtime.Graph.RecalculateCurveDirectionsNode> {
+        protected override string Title => "Recalculate Directions";
+        protected override NodeCategory Category => NodeCategory.Curve;
+
+        private GraphFrameworkPort curvePort;
+        private GraphFrameworkPort resultPort;
+
+        private bool flipTangents;
+        private bool flipNormals;
+        private bool flipBinormals;
+
+        private BooleanToggle flipTangentsToggle;
+        private BooleanToggle flipNormalsToggle;
+        private BooleanToggle flipBinormalsToggle;
+
+        protected override void CreateNode() {
+            curvePort = GraphFrameworkPort.Create("Curve", Direction.Input, Port.Capacity.Single, PortType.Curve, this);
+            resultPort = GraphFrameworkPort.Create("Curve", Direction.Output, Port.Capacity.Multi, PortType.Curve, this);
+
+            flipTangentsToggle = new BooleanToggle(false, "Flip Tangents (Yes)", "Flip Tangents (No)");
+            flipNormalsToggle = new BooleanToggle(false, "Flip Normals (Yes)", "Flip Normals (No)");
+            flipBinormalsToggle = new BooleanToggle(false, "Flip Binormals (Yes)", "Flip Binormals (No)");
+
+            flipTangentsToggle.RegisterValueChangedCallback(evt => {
+                if (evt.newValue == flipTangents) return;
+
+                Owner.EditorView.GraphObject.RegisterCompleteObjectUndo("Change Flip Tangents");
+                flipTangents = evt.newValue;
+                RuntimeNode.UpdateFlipTangents(flipTangents);
+            });
+
+            flipNormalsToggle.RegisterValueChangedCallback(evt => {
+                if (evt.newValue == flipNormals) return;
+
+                Owner.EditorView.GraphObject.RegisterCompleteObjectUndo("Change Flip Normals");
+                flipNormals = evt.newValue;
+                RuntimeNode.UpdateFlipNormals(flipNormals);
+            });
+
+            flipBinormalsToggle.RegisterValueChangedCallback(evt => {
+                if (evt.newValue == flipBinormals) return;
+
+                Owner.EditorView.GraphObject.RegisterCompleteObjectUndo("Change Flip Binormals");
+                flipBinormals = evt.newValue;
+                RuntimeNode.UpdateFlipBinormals(flipBinormals);
+            });
+
+            inputContainer.Add(flipTangentsToggle);
+            inputContainer.Add(flipNormalsToggle);
+            inputContainer.Add(flipBinormalsToggle);
+            AddPort(curvePort);
+            AddPort(resultPort);
+        }
+
+        protected override void BindPorts() {
+            BindPort(curvePort, RuntimeNode.CurvePort);
+            BindPort(resultPort, RuntimeNode.ResultPort);
+        }
+
+        protected internal override JObject Serialize() {
+            JObject root = base.Serialize();
+            JArray data = new() {
+                flipTangents ? 1 : 0,
+                flipNormals ? 1 : 0,
+                flipBinormals ? 1 : 0
+            };
+
+            root["d"] = data;
+            return root;
+        }
+
+        protected internal override void Deserialize(JObject data) {
+            JArray array = data["d"] as JArray;
+
+            flipTangents = array!.Value<int>(0) == 1;
+            flipNormals = array.Value<int>(1) == 1;
+            flipBinormals = array.Value<int>(2) == 1;
+
+            flipTangentsToggle.SetValueWithoutNotify(flipTangents);
+            flipNormalsToggle.SetValueWithoutNotify(flipNormals);
+            flipBinormalsToggle.SetValueWithoutNotify(flipBinormals);
+
+            RuntimeNode.UpdateFlipTangents(flipTangents);
+            RuntimeNode.UpdateFlipNormals(flipNormals);
+            RuntimeNode.UpdateFlipBinormals(flipBinormals);
+
+            base.Deserialize(data);
+        }
+    }
+}
diff --git a/UnityGeometryGraph/Assets/GeometryGraph/Editor/Graph/Nodes/Curve/RecalculateCurveDirectionsNode.cs.meta b/UnityGeometryGraph/Assets/GeometryGraph/Editor/Graph/Nodes/Curve/RecalculateCurveDirectionsNode.cs.meta
diff --git a/UnityGeometryGraph/Assets/GeometryGraph/Runtime/Graph/Node/Curve/RecalculateCurveDirectionsNode.cs b/UnityGeometryGraph/Assets/GeometryGraph/Runtime/Graph/Node/Curve/RecalculateCurveDirectionsNode.cs
@@ -2,18 +2,36 @@
 using GeometryGraph.Runtime.Curve;
 
 namespace GeometryGraph.Runtime.Graph {
+    [GenerateRuntimeNode]
     public partial class RecalculateCurveDirectionsNode {
         [In(
-            DefaultValue = "(CurveData)null",
+            DefaultValue = "CurveData.Empty",
             GetValueCode = "{self} = GetValue(connection, {default})",
             UpdateValueCode = ""
         )]
         public CurveData Curve { get; private set; }
+
         [Out] public CurveData Result { get; private set; }
 
+        [Setting] public bool FlipTangents { get; private set; }
+        [Setting] public bool FlipNormals { get; private set; }
+        [Setting] public bool FlipBinormals { get; private set; }
+
+        protected override void OnConnectionRemoved(Connection connection, RuntimePort port) {
+            if (port == CurvePort) {
+                Curve = CurveData.Empty;
+                Result = CurveData.Empty;
+            }
+        }
+
         [CalculatesProperty(nameof(Result))]
         private void CalculateResult() {
-            // TODO: Implement
+            if (Curve == null) {
+                Result = CurveData.Empty;
+                return;
+            }
+
+            Result = CurveOperations.RecalculateDirectionVectors(Curve, new RecalculateCurveDirectionsSettings(FlipTangents, FlipNormals, FlipBinormals));
         }
     }
 }
diff --git a/UnityGeometryGraph/Assets/GeometryGraph/Runtime/Graph/Node/Curve/TransformCurveNode.cs b/UnityGeometryGraph/Assets/GeometryGraph/Runtime/Graph/Node/Curve/TransformCurveNode.cs
@@ -40,13 +40,13 @@ public partial class TransformCurveNode {
 
         protected override void OnConnectionRemoved(Connection connection, RuntimePort port) {
             if (port != InputPort) return;
-            Result = null;
+            Result = CurveData.Empty;
         }
 
         [CalculatesProperty(nameof(Result))]
         private void CalculateResult() {
             if (Input == null) {
-                Result = null;
+                Result = CurveData.Empty;
                 return;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -40,13 +40,13 @@ public partial class TransformCurveNode {`
`40`	`40`
`41`	`41`	`protected override void OnConnectionRemoved(Connection connection, RuntimePort port) {`
`42`	`42`	`if (port != InputPort) return;`
`43`		`- Result = null;`
	`43`	`+ Result = CurveData.Empty;`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`[CalculatesProperty(nameof(Result))]`
`47`	`47`	`private void CalculateResult() {`
`48`	`48`	`if (Input == null) {`
`49`		`- Result = null;`
	`49`	`+ Result = CurveData.Empty;`
`50`	`50`	`return;`
`51`	`51`	`}`
`52`	`52`