testing: improving GenerateSubsetsTest (#6412)

alxkm · DenizAltunkapan · web-flow · commit 78b62191ab09 · 2025-07-22T18:49:37.000+02:00
* testing: improving GenerateSubsetsTest

* testing: change List to more common Iterable

---------

Co-authored-by: Deniz Altunkapan &lt;93663085+DenizAltunkapan@users.noreply.github.com&gt;
diff --git a/src/test/java/com/thealgorithms/recursion/GenerateSubsetsTest.java b/src/test/java/com/thealgorithms/recursion/GenerateSubsetsTest.java
@@ -1,36 +1,40 @@
 package com.thealgorithms.recursion;
 
-import static org.junit.jupiter.api.Assertions.assertArrayEquals;
+import static org.junit.jupiter.api.Assertions.assertIterableEquals;
 
+import java.util.Arrays;
 import java.util.List;
+import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 
 public final class GenerateSubsetsTest {
 
     @Test
-    void subsetRecursionTestOne() {
-        String str = "abc";
-        String[] expected = new String[] {"abc", "ab", "ac", "a", "bc", "b", "c", ""};
-
-        List<String> ans = GenerateSubsets.subsetRecursion(str);
-        assertArrayEquals(ans.toArray(), expected);
+    @DisplayName("Subsets of 'abc'")
+    void testSubsetsOfABC() {
+        assertSubsets("abc", Arrays.asList("abc", "ab", "ac", "a", "bc", "b", "c", ""));
     }
 
     @Test
-    void subsetRecursionTestTwo() {
-        String str = "cbf";
-        String[] expected = new String[] {"cbf", "cb", "cf", "c", "bf", "b", "f", ""};
+    @DisplayName("Subsets of 'cbf'")
+    void testSubsetsOfCBF() {
+        assertSubsets("cbf", Arrays.asList("cbf", "cb", "cf", "c", "bf", "b", "f", ""));
+    }
 
-        List<String> ans = GenerateSubsets.subsetRecursion(str);
-        assertArrayEquals(ans.toArray(), expected);
+    @Test
+    @DisplayName("Subsets of 'aba' with duplicates")
+    void testSubsetsWithDuplicateChars() {
+        assertSubsets("aba", Arrays.asList("aba", "ab", "aa", "a", "ba", "b", "a", ""));
     }
 
     @Test
-    void subsetRecursionTestThree() {
-        String str = "aba";
-        String[] expected = new String[] {"aba", "ab", "aa", "a", "ba", "b", "a", ""};
+    @DisplayName("Subsets of empty string")
+    void testEmptyInput() {
+        assertSubsets("", List.of(""));
+    }
 
-        List<String> ans = GenerateSubsets.subsetRecursion(str);
-        assertArrayEquals(ans.toArray(), expected);
+    private void assertSubsets(String input, Iterable<String> expected) {
+        List<String> actual = GenerateSubsets.subsetRecursion(input);
+        assertIterableEquals(expected, actual, "Subsets do not match for input: " + input);
     }
 }
