Fixed build failure due to suboptimal expression in newly added tests

pushkar · pushkar · commit e35bf2b9debe · 2025-07-06T19:19:10.000+05:30
diff --git a/src/test/java/com/thealgorithms/sorts/AdaptiveMergeSortTest.java b/src/test/java/com/thealgorithms/sorts/AdaptiveMergeSortTest.java
@@ -107,11 +107,14 @@ public int compareTo(Person o) {
 
         @Override
         public boolean equals(Object o) {
-            if (!(o instanceof Person)) {
+            if (this == o) {
+                return true;
+            }
+            if (o == null || getClass() != o.getClass()) {
                 return false;
             }
-            Person p = (Person) o;
-            return this.name.equals(p.name) && this.age == p.age;
+            Person person = (Person) o;
+            return age == person.age && Objects.equals(name, person.name);
         }
 
         @Override
diff --git a/src/test/java/com/thealgorithms/sorts/BogoSortTest.java b/src/test/java/com/thealgorithms/sorts/BogoSortTest.java
@@ -116,11 +116,14 @@ public int compareTo(Person o) {
 
         @Override
         public boolean equals(Object o) {
-            if (!(o instanceof Person)) {
+            if (this == o) {
+                return true;
+            }
+            if (o == null || getClass() != o.getClass()) {
                 return false;
             }
-            Person p = (Person) o;
-            return this.name.equals(p.name) && this.age == p.age;
+            Person person = (Person) o;
+            return age == person.age && Objects.equals(name, person.name);
         }
 
         @Override
diff --git a/src/test/java/com/thealgorithms/sorts/BubbleSortTest.java b/src/test/java/com/thealgorithms/sorts/BubbleSortTest.java
@@ -144,11 +144,14 @@ public int compareTo(Person o) {
 
         @Override
         public boolean equals(Object o) {
-            if (!(o instanceof Person)) {
+            if (this == o) {
+                return true;
+            }
+            if (o == null || getClass() != o.getClass()) {
                 return false;
             }
-            Person p = (Person) o;
-            return this.name.equals(p.name) && this.age == p.age;
+            Person person = (Person) o;
+            return age == person.age && Objects.equals(name, person.name);
         }
 
         @Override
diff --git a/src/test/java/com/thealgorithms/sorts/GnomeSortTest.java b/src/test/java/com/thealgorithms/sorts/GnomeSortTest.java
@@ -137,11 +137,14 @@ public int compareTo(Person o) {
 
         @Override
         public boolean equals(Object o) {
-            if (!(o instanceof Person)) {
+            if (this == o) {
+                return true;
+            }
+            if (o == null || getClass() != o.getClass()) {
                 return false;
             }
-            Person p = (Person) o;
-            return this.name.equals(p.name) && this.age == p.age;
+            Person person = (Person) o;
+            return age == person.age && Objects.equals(name, person.name);
         }
 
         @Override
diff --git a/src/test/java/com/thealgorithms/sorts/InsertionSortTest.java b/src/test/java/com/thealgorithms/sorts/InsertionSortTest.java
@@ -164,11 +164,14 @@ public int compareTo(Person o) {
 
         @Override
         public boolean equals(Object o) {
-            if (!(o instanceof Person)) {
+            if (this == o) {
+                return true;
+            }
+            if (o == null || getClass() != o.getClass()) {
                 return false;
             }
-            Person p = (Person) o;
-            return this.name.equals(p.name) && this.age == p.age;
+            Person person = (Person) o;
+            return age == person.age && Objects.equals(name, person.name);
         }
 
         @Override
diff --git a/src/test/java/com/thealgorithms/sorts/SlowSortTest.java b/src/test/java/com/thealgorithms/sorts/SlowSortTest.java
@@ -129,11 +129,14 @@ public int compareTo(Person o) {
 
         @Override
         public boolean equals(Object o) {
-            if (!(o instanceof Person)) {
+            if (this == o) {
+                return true;
+            }
+            if (o == null || getClass() != o.getClass()) {
                 return false;
             }
-            Person p = (Person) o;
-            return this.name.equals(p.name) && this.age == p.age;
+            Person person = (Person) o;
+            return age == person.age && Objects.equals(name, person.name);
         }
 
         @Override
