Skip to content

refactor: improving readability DecimalToAnyUsingStack #6377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Jul 13, 2025

  • Extracted digit lookup table to a private static final field to avoid redundant creation.
  • Added comprehensive JavaDoc for the class, method, and fields to improve readability and maintainability.
  • Improved variable naming for clarity (tables → DIGITS, bits → digitStack).
  • Minor code clean-up for better structure and readability.
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.62%. Comparing base (95116db) to head (c941396).

Files with missing lines Patch % Lines
...ms/dynamicprogramming/SubsetSumSpaceOptimized.java 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6377      +/-   ##
============================================
- Coverage     74.64%   74.62%   -0.02%     
- Complexity     5454     5455       +1     
============================================
  Files           682      682              
  Lines         19008    19009       +1     
  Branches       3671     3671              
============================================
- Hits          14188    14185       -3     
- Misses         4260     4262       +2     
- Partials        560      562       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DenizAltunkapan DenizAltunkapan enabled auto-merge (squash) July 15, 2025 05:24
@DenizAltunkapan DenizAltunkapan merged commit 7e37d94 into TheAlgorithms:master Jul 15, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy