From 65efd5de680058b1f93ddaeef7534c0ddc280810 Mon Sep 17 00:00:00 2001 From: alxkm Date: Wed, 16 Jul 2025 23:03:02 +0200 Subject: [PATCH 1/3] testing: improve test coverage DuplicateBracketsTest --- .../stacks/DuplicateBracketsTest.java | 31 +++++++++++++++++-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/src/test/java/com/thealgorithms/stacks/DuplicateBracketsTest.java b/src/test/java/com/thealgorithms/stacks/DuplicateBracketsTest.java index e2cc6acb8112..ba7e60e00b21 100644 --- a/src/test/java/com/thealgorithms/stacks/DuplicateBracketsTest.java +++ b/src/test/java/com/thealgorithms/stacks/DuplicateBracketsTest.java @@ -4,20 +4,23 @@ import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; +import java.util.stream.Stream; import org.junit.jupiter.api.Test; import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.Arguments; import org.junit.jupiter.params.provider.CsvSource; +import org.junit.jupiter.params.provider.MethodSource; class DuplicateBracketsTest { @ParameterizedTest - @CsvSource({"'((a + b) + (c + d))'", "'(a + b)'", "'a + b'", "'('", "''"}) + @CsvSource({"'((a + b) + (c + d))'", "'(a + b)'", "'a + b'", "'('", "''", "'a + (b * c) - d'", "'(x + y) * (z)'", "'(a + (b - c))'"}) void testInputReturnsFalse(String input) { assertFalse(DuplicateBrackets.check(input)); } @ParameterizedTest - @CsvSource({"'(a + b) + ((c + d))'", "'((a + b))'", "'((((a + b)))))'"}) + @CsvSource({"'(a + b) + ((c + d))'", "'((a + b))'", "'((((a + b)))))'", "'((x))'", "'((a + (b)))'", "'(a + ((b)))'", "'(((a)))'", "'(((())))'"}) void testInputReturnsTrue(String input) { assertTrue(DuplicateBrackets.check(input)); } @@ -26,4 +29,28 @@ void testInputReturnsTrue(String input) { void testInvalidInput() { assertThrows(IllegalArgumentException.class, () -> DuplicateBrackets.check(null)); } + + @ParameterizedTest(name = "Should be true: \"{0}\"") + @MethodSource("provideInputsThatShouldReturnTrue") + void testDuplicateBracketsTrueCases(String input) { + assertTrue(DuplicateBrackets.check(input)); + } + + static Stream provideInputsThatShouldReturnTrue() { + return Stream.of(Arguments.of("()"), Arguments.of("(( ))")); + } + + @ParameterizedTest(name = "Should be false: \"{0}\"") + @MethodSource("provideInputsThatShouldReturnFalse") + void testDuplicateBracketsFalseCases(String input) { + assertFalse(DuplicateBrackets.check(input)); + } + + static Stream provideInputsThatShouldReturnFalse() { + return Stream.of( + Arguments.of("( )"), // whitespace inside brackets + Arguments.of("abc + def"), // no brackets + Arguments.of("(a + (b * c)) - (d / e)") // complex, but no duplicates + ); + } } From e7adb6d249a7f4ed490f0ecefb2f386bc97042d7 Mon Sep 17 00:00:00 2001 From: alxkm Date: Wed, 16 Jul 2025 23:05:38 +0200 Subject: [PATCH 2/3] style: fix formatting checkstyle --- .../java/com/thealgorithms/stacks/DuplicateBracketsTest.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/test/java/com/thealgorithms/stacks/DuplicateBracketsTest.java b/src/test/java/com/thealgorithms/stacks/DuplicateBracketsTest.java index ba7e60e00b21..3508faf2f42b 100644 --- a/src/test/java/com/thealgorithms/stacks/DuplicateBracketsTest.java +++ b/src/test/java/com/thealgorithms/stacks/DuplicateBracketsTest.java @@ -47,8 +47,7 @@ void testDuplicateBracketsFalseCases(String input) { } static Stream provideInputsThatShouldReturnFalse() { - return Stream.of( - Arguments.of("( )"), // whitespace inside brackets + return Stream.of(Arguments.of("( )"), // whitespace inside brackets Arguments.of("abc + def"), // no brackets Arguments.of("(a + (b * c)) - (d / e)") // complex, but no duplicates ); From 5aff75322784cc5de65f522af35dd9d95e84f92d Mon Sep 17 00:00:00 2001 From: alxkm Date: Wed, 16 Jul 2025 23:06:38 +0200 Subject: [PATCH 3/3] style: fix formatting checkstyle --- .../java/com/thealgorithms/stacks/DuplicateBracketsTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/java/com/thealgorithms/stacks/DuplicateBracketsTest.java b/src/test/java/com/thealgorithms/stacks/DuplicateBracketsTest.java index 3508faf2f42b..bc7b3266d98e 100644 --- a/src/test/java/com/thealgorithms/stacks/DuplicateBracketsTest.java +++ b/src/test/java/com/thealgorithms/stacks/DuplicateBracketsTest.java @@ -48,8 +48,8 @@ void testDuplicateBracketsFalseCases(String input) { static Stream provideInputsThatShouldReturnFalse() { return Stream.of(Arguments.of("( )"), // whitespace inside brackets - Arguments.of("abc + def"), // no brackets - Arguments.of("(a + (b * c)) - (d / e)") // complex, but no duplicates + Arguments.of("abc + def"), // no brackets + Arguments.of("(a + (b * c)) - (d / e)") // complex, but no duplicates ); } } pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy