fix: updated CONTRIBUTING.md and added test cases for Moore Voting Algorithm

Mrinal Chauhan · Mrinal Chauhan · commit 193763d5aa7e · 2024-10-25T03:19:15.000+05:30
diff --git a/.husky/pre-commit b/.husky/pre-commit
diff --git a/DIRECTORY.md b/DIRECTORY.md
@@ -73,6 +73,7 @@
     * [NumberOfLocalMaximumPoints](Data-Structures/Array/NumberOfLocalMaximumPoints.js)
     * [QuickSelect](Data-Structures/Array/QuickSelect.js)
     * [Reverse](Data-Structures/Array/Reverse.js)
+    * [MooreVotingAlgorithm](Data-Structures/Array/MooreVotingAlgorithm.js)
   * **Graph**
     * [Graph](Data-Structures/Graph/Graph.js)
     * [Graph2](Data-Structures/Graph/Graph2.js)
diff --git a/Data-Structures/Array/MooreVotingAlgorithm.js b/Data-Structures/Array/MooreVotingAlgorithm.js
@@ -6,29 +6,24 @@
  * @returns {Number} majority element or null if no majority exists
  */
 const MooreVotingAlgorithm = (arr) => {
-    let candidate = null;
-    let count = 0;
-  
-    // Phase 1: Finding the candidate
-    for (let num of arr) {
-      if (count === 0) {
-        candidate = num;
-        count = 1;
-      } else if (num === candidate) {
-        count++;
-      } else {
-        count--;
-      }
+  let candidate = null
+  let count = 0
+
+  // Phase 1: Find the candidate for majority element
+  for (let num of arr) {
+    if (count === 0) {
+      candidate = num
     }
-  
-    // Phase 2: Validate the candidate
-    count = 0;
-    for (let num of arr) {
-      if (num === candidate) {
-        count++;
-      }
+    count += num === candidate ? 1 : -1
+  }
+
+  // Phase 2: Verify if the candidate is actually the majority element
+  count = 0
+  for (let num of arr) {
+    if (num === candidate) {
+      count++
     }
-  
-    return count > arr.length / 2 ? candidate : null;
-  };
-  export { MooreVotingAlgorithm };
+  }
+  return count > arr.length / 2 ? candidate : null
+}
+export { MooreVotingAlgorithm }
diff --git a/Data-Structures/Array/test/MooreVotingAlgorithm.test.js b/Data-Structures/Array/test/MooreVotingAlgorithm.test.js
@@ -1,12 +1,11 @@
-import {MooreVotingAlgorithm} from "../MooreVotingAlgorithm";
+import { MooreVotingAlgorithm } from '../MooreVotingAlgorithm'
 describe('Moore Voting Algorithm', () => {
-    it.each([
-      [[1, 1, 2, 1, 3, 1, 1], 1], // Majority element 1
-      [[1, 2, 3, 4], null],        // No majority element
-      [[2, 2, 2, 2, 5, 5, 5, 2], 2], // Majority element 2
-      [[], null],                  // Empty array, no majority
-      [[3], 3]                     // Single element, it's the majority
-    ])('returns %j when given %j', (array, expected) => {
-      expect(MooreVotingAlgorithm(array)).toEqual(expected);
-    });
-  });
+  it.each([
+    [[1, 1, 2, 1, 3, 1, 1], 1], // Majority element 1
+    [[2, 2, 2, 2, 5, 5, 5, 2], 2], // Majority element 2
+    [[3], 3], // Single element, it's the majority
+    [[1, 2, 3, 4, 5, 6, 7], null] // No majority element in the array
+  ])('returns %j when given %j', (array, expected) => {
+    expect(MooreVotingAlgorithm(array)).toEqual(expected)
+  })
+})
diff --git a/Maths/MobiusFunction.js b/Maths/MobiusFunction.js
@@ -28,6 +28,6 @@ export const mobiusFunction = (number) => {
   return primeFactorsArray.length !== new Set(primeFactorsArray).size
     ? 0
     : primeFactorsArray.length % 2 === 0
-    ? 1
-    : -1
+      ? 1
+      : -1
 }
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -13,11 +13,11 @@
   "author": "TheAlgorithms",
   "license": "GPL-3.0",
   "devDependencies": {
+    "@vitest/coverage-v8": "^1.2.1",
     "globby": "^13.2.2",
     "husky": "^8.0.3",
-    "prettier": "^3.0.3",
-    "vitest": "^1.2.1",
-    "@vitest/coverage-v8": "^1.2.1"
+    "prettier": "^3.3.3",
+    "vitest": "^1.2.1"
   },
   "engines": {
     "node": ">=20.6.0"

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,6 @@ export const mobiusFunction = (number) => {`
`28`	`28`	`return primeFactorsArray.length !== new Set(primeFactorsArray).size`
`29`	`29`	`? 0`
`30`	`30`	`: primeFactorsArray.length % 2 === 0`
`31`		`- ? 1`
`32`		`- : -1`
	`31`	`+ ? 1`
	`32`	`+ : -1`
`33`	`33`	`}`