Resolved comments and changes requests

developerr-ayush · developerr-ayush · commit 5733b78cf66c · 2023-10-03T07:05:54.000+05:30
diff --git a/Maths/TwoSum.js b/Maths/TwoSum.js
@@ -1,22 +1,23 @@
-/*
-Given an array of integers, return indices of the two numbers such that they add up to
-a specific target.
-
-You may assume that each input would have exactly one solution, and you may not use the
-same element twice.
-
-Example
-Given nums = [2, 7, 11, 15], target = 9,
-Because nums[0] + nums[1] = 2 + 7 = 9, return [0, 1].
-return [0, 1].
-*/
+/**
+ * Given an array of integers, find two numbers that add up to a specific target.
+ *
+ * @param {number[]} nums - The array of integers.
+ * @param {number} target - The target sum.
+ * @returns {number[]} - An array containing the indices of the two numbers.
+ *
+ * @example
+ * const nums = [2, 7, 11, 15];
+ * const target = 9;
+ * const result = twoSum(nums, target);
+ * // The function should return [0, 1] because nums[0] + nums[1] = 2 + 7 = 9.
+ */
 
 const TwoSum = (nums, target) => {
-  const numIndicesMap = {}
+  const numIndicesMap = new Map()
   for (let i = 0; i < nums.length; i++) {
     const complement = target - nums[i]
-    if (complement in numIndicesMap) return [numIndicesMap[complement], i]
-    numIndicesMap[nums[i]] = i
+    if (numIndicesMap.has(complement)) return [numIndicesMap.get(complement), i]
+    numIndicesMap.set(nums[i], i)
   }
   return []
 }
diff --git a/Maths/test/TwoSum.test.js b/Maths/test/TwoSum.test.js
@@ -1,18 +1,28 @@
 import { TwoSum } from '../TwoSum.js'
-
 describe('Two Sum', () => {
-  it('Should find the indices of two numbers that add up to the target', () => {
-    expect(TwoSum([2, 7, 11, 15], 9)).toEqual([0, 1])
-    expect(TwoSum([15, 2, 11, 7], 13)).toEqual([1, 2])
-    expect(TwoSum([2, 7, 11, 15], 17)).toEqual([0, 3])
-    expect(TwoSum([7, 15, 11, 2], 18)).toEqual([0, 2])
-    expect(TwoSum([2, 7, 11, 15], 26)).toEqual([2, 3])
-    expect(TwoSum([2, 7, 11, 15], 8)).toEqual([])
-    expect(
-      TwoSum(
-        [...Array(10).keys()].map((i) => 3 * i),
-        19
-      )
-    ).toEqual([])
-  })
+  const testCasesWithoutSolution = [
+    [[8], 8],
+    [[3, 3, 3, 3], 19]
+  ]
+  const testCasesWithSolution = [
+    [[2, 7, 11, 15], 9, [0, 1]],
+    [[15, 2, 11, 7], 13, [1, 2]],
+    [[2, 7, 11, 15], 17, [0, 3]],
+    [[7, 15, 11, 2], 18, [0, 2]],
+    [[2, 7, 11, 15], 26, [2, 3]]
+  ]
+
+  test.each(testCasesWithoutSolution)(
+    'Should return an empty array if there is no solution',
+    (nums, target) => {
+      expect(TwoSum(nums, target)).toEqual([])
+    }
+  )
+
+  test.each(testCasesWithSolution)(
+    'Should return the indices of two numbers that add up to the target',
+    (nums, target, expected) => {
+      expect(TwoSum(nums, target)).toEqual(expected)
+    }
+  )
 })
