fix: seperate the test loops of error cases

piyushk77 · piyushk77 · commit 95062050b487 · 2023-10-09T12:46:44.000+05:30
diff --git a/Maths/test/Determinant.test.js b/Maths/test/Determinant.test.js
@@ -1,7 +1,7 @@
 import { expect } from 'vitest'
 import { determinant } from '../Determinant'
 describe('Determinant', () => {
-  const testCases = [
+  const validTestCases = [
     [
       [
         [8, 1, 6],
@@ -36,7 +36,10 @@ describe('Determinant', () => {
       ],
       2476
     ],
-    [[[23]], 23],
+    [[[23]], 23]
+  ]
+
+  const errorTestCases = [
     [
       [
         [1, 6],
@@ -48,7 +51,7 @@ describe('Determinant', () => {
     [[1, 3, 2, [5, 8, 6], 3], 'Input is not a valid 2D matrix.']
   ]
 
-  test.each(testCases)(
+  test.each(validTestCases)(
     'Should return the determinant of the square matrix.',
     (matrix, expected) => {
       try {
@@ -58,4 +61,15 @@ describe('Determinant', () => {
       }
     }
   )
+
+  test.each(errorTestCases)(
+    'Should return the error message.',
+    (matrix, expected) => {
+      try {
+        expect(determinant(matrix)).toEqual(expected)
+      } catch (err) {
+        expect(err.message).toEqual(expected)
+      }
+    }
+  )
 })

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`import { expect } from 'vitest'`
`2`	`2`	`import { determinant } from '../Determinant'`
`3`	`3`	`describe('Determinant', () => {`
`4`		`- const testCases = [`
	`4`	`+ const validTestCases = [`
`5`	`5`	`[`
`6`	`6`	`[`
`7`	`7`	`[8, 1, 6],`
`@@ -36,7 +36,10 @@ describe('Determinant', () => {`
`36`	`36`	`],`
`37`	`37`	`2476`
`38`	`38`	`],`
`39`		`- [[[23]], 23],`
	`39`	`+ [[[23]], 23]`
	`40`	`+ ]`
	`41`	`+`
	`42`	`+ const errorTestCases = [`
`40`	`43`	`[`
`41`	`44`	`[`
`42`	`45`	`[1, 6],`
`@@ -48,7 +51,7 @@ describe('Determinant', () => {`
`48`	`51`	`[[1, 3, 2, [5, 8, 6], 3], 'Input is not a valid 2D matrix.']`
`49`	`52`	`]`
`50`	`53`
`51`		`- test.each(testCases)(`
	`54`	`+ test.each(validTestCases)(`
`52`	`55`	`'Should return the determinant of the square matrix.',`
`53`	`56`	`(matrix, expected) => {`
`54`	`57`	`try {`
`@@ -58,4 +61,15 @@ describe('Determinant', () => {`
`58`	`61`	`}`
`59`	`62`	`}`
`60`	`63`	`)`
	`64`	`+`
	`65`	`+ test.each(errorTestCases)(`
	`66`	`+ 'Should return the error message.',`
	`67`	`+ (matrix, expected) => {`
	`68`	`+ try {`
	`69`	`+ expect(determinant(matrix)).toEqual(expected)`
	`70`	`+ } catch (err) {`
	`71`	`+ expect(err.message).toEqual(expected)`
	`72`	`+ }`
	`73`	`+ }`
	`74`	`+ )`
`61`	`75`	`})`