parametrize over different reduction operations

TomNicholas · TomNicholas · commit 5ef82b9ddc51 · 2024-08-22T17:11:33.000-04:00
diff --git a/xarray_array_testing/reduction.py b/xarray_array_testing/reduction.py
@@ -1,5 +1,7 @@
 from contextlib import nullcontext
 
+import pytest
+
 import hypothesis.strategies as st
 import xarray.testing.strategies as xrst
 from hypothesis import given
@@ -12,22 +14,15 @@ class ReductionTests(DuckArrayTestMixin):
     def expected_errors(op, **parameters):
         return nullcontext()
 
+    @pytest.mark.parametrize("op", ["mean", "sum", "prod", "std", "var"])
     @given(st.data())
-    def test_variable_mean(self, data):
-        variable = data.draw(xrst.variables(array_strategy_fn=self.array_strategy_fn))
-
-        with self.expected_errors("mean", variable=variable):
-            actual = variable.mean().data
-            expected = self.xp.mean(variable.data)
-
-        self.assert_equal(actual, expected)
-
-    @given(st.data())
-    def test_variable_prod(self, data):
+    def test_variable_mean(self, op, data):
         variable = data.draw(xrst.variables(array_strategy_fn=self.array_strategy_fn))
 
-        with self.expected_errors("prod", variable=variable):
-            actual = variable.prod().data
-            expected = self.xp.prod(variable.data)
+        with self.expected_errors(op, variable=variable):
+            # compute using xr.Variable.<OP>()
+            actual = getattr(variable, op)().data
+            # compute using xp.<OP>(array)
+            expected = getattr(self.xp, op)(variable.data)
 
         self.assert_equal(actual, expected)
