AnimationSystem2 support #876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for the new AnimationSystem2 implementation by adding a new AnimationClip resource type (NmClip) and integrating it into the animation pipeline and viewer modules.
- Added AnimationClip class in ModelAnimation2 for parsing and handling new animation data.
- Extended the Skeleton and Animation classes to support the new data formats and integrated the new resource type in Resource, Viewer, and Renderer layers.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ValveResourceFormat/Resource/ResourceTypes/ModelAnimation2/AnimationClip.cs | Implements reading and decoding for new animation clip data. |
| ValveResourceFormat/Resource/ResourceTypes/ModelAnimation/Skeleton.cs | Introduces a new Skeleton constructor from NmSkeleton and updates bone parent assignment. |
| ValveResourceFormat/Resource/ResourceTypes/ModelAnimation/Animation.cs | Integrates the new AnimationClip within the existing Animation framework. |
| ValveResourceFormat/Resource/Resource.cs | Registers the new NmClip resource type. |
| GUI/Types/Viewers/Resource.cs | Adds a new viewer case for the AnimationClip resource. |
| GUI/Types/Renderer/SkeletonSceneNode.cs | Adjusts animation update logic to account for the new Animation2 property. |
| GUI/Types/Renderer/GLModelViewer.cs | Adds support for rendering the new AnimationClip by initializing the appropriate AnimationController. |
Co-Authored-By: Pavel Djundik <xPaw@users.noreply.github.com>
Co-Authored-By: Pavel Djundik <xPaw@users.noreply.github.com>
kristiker
commented
Jul 29, 2025
GUI/Types/Renderer/GLModelViewer.cs
Outdated
Comment on lines
53
to
57
| public GLModelViewer(VrfGuiContext guiContext, AnimationClip anim) : base(guiContext) | ||
| { | ||
| this.clip = anim; | ||
| } | ||
|
|
There was a problem hiding this comment.
It might be better to make a different class. Maybe later on.
xPaw
reviewed
Jul 29, 2025
GUI/Types/Renderer/GLSceneViewer.cs
Outdated
| @@ -255,6 +255,11 @@ public virtual void PostSceneLoad() | |||
| offset = Math.Clamp(offset, 0f, 2000f); | |||
| var location = new Vector3(offset, 0, offset); | |||
|
|
|||
| if (this is GLModelViewer { clip: not null }) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Valve is developing a new animation system for Source 2 and has pushed a few resource files in Deadlock and CS2 that we can experiment with. Open source implementation that inspires this new Source 2 system can be found here.
TODO