Do not use objects for queued mails

thelfensdrfer · thelfensdrfer · commit 54b00a092639 · 2015-01-06T11:35:31.000+01:00
diff --git a/app/jobs/CheckWebsite.php b/app/jobs/CheckWebsite.php
@@ -41,9 +41,13 @@ public function fire(Illuminate\Queue\Jobs\Job $job, $data)
 
 		if ($response->success) {
 			if (isset($lastCheck) && !$lastCheck->success) {
-				Mail::queue('email.check.online', array('check' => $check), function($message) use($check) {
-					$message->to($check->theUser->email)
-						->subject(trans('check.job.email.online.subject', array('title' => $check->title)));
+				Mail::queue('email.check.online', array(
+						'id' => $check->id,
+						'title' => $check->title,
+					),
+					function($message) use($check) {
+						$message->to($check->theUser->email)
+							->subject(trans('check.job.email.online.subject', array('title' => $check->title)));
 				});
 			}
 
@@ -59,10 +63,14 @@ public function fire(Illuminate\Queue\Jobs\Job $job, $data)
 			}
 		} else {
 			if (isset($lastCheck) && $lastCheck->success) {
-				Mail::queue('email.check.offline', array('check' => $check, 'response' => $response), function($message) use($check) {
-					$message->to($check->theUser->email)
-						->subject(trans('check.job.email.offline.subject', array('title' => $check->title)));
-
+				Mail::queue('email.check.offline', array(
+						'id' => $check->id,
+						'title' => $check->title,
+						'statusCode' => $response->status_code
+					),
+					function($message) use($check) {
+						$message->to($check->theUser->email)
+							->subject(trans('check.job.email.offline.subject', array('title' => $check->title)));
 				});
 			}
 
diff --git a/app/views/email/check/offline.blade.php b/app/views/email/check/offline.blade.php
@@ -7,5 +7,5 @@
 @section('content')
 	<h1>{{ trans('check.job.email.offline.headline') }}</h1>
 
-	<p>{{ trans('check.job.email.offline.content', array('url' => URL::route('check.show', array('id' => $check->id)), 'title' => $check->title, 'code' => $response->status_code)) }}</p>
-@stop
+	<p>{{ trans('check.job.email.offline.content', array('url' => URL::route('check.show', array('id' => $id)), 'title' => $title, 'code' => $statusCode)) }}</p>
+@stop
diff --git a/app/views/email/check/online.blade.php b/app/views/email/check/online.blade.php
@@ -7,5 +7,5 @@
 @section('content')
 	<h1>{{ trans('check.job.email.online.headline') }}</h1>
 
-	<p>{{ trans('check.job.email.online.content', array('url' => URL::route('check.show', array('id' => $check->id)), 'title' => $check->title)) }}</p>
-@stop
+	<p>{{ trans('check.job.email.online.content', array('url' => URL::route('check.show', array('id' => $id)), 'title' => $title)) }}</p>
+@stop
