Merge branch 'main'

JoshuaKGoldberg · JoshuaKGoldberg · commit 04f19381af02 · 2024-05-08T17:55:18.000-07:00
diff --git a/docs/users/Shared_Configurations.mdx b/docs/users/Shared_Configurations.mdx
@@ -375,7 +375,7 @@ Additionally, it enables rules that promote using the more modern constructs Typ
 ```js title="eslint.config.js"
 export default tseslint.config(
   eslint.configs.recommended,
-  ...tseslint.configs.eslintRecommended,
+  tseslint.configs.eslintRecommended,
 );
 ```
 
diff --git a/packages/eslint-plugin/docs/rules/consistent-type-imports.mdx b/packages/eslint-plugin/docs/rules/consistent-type-imports.mdx
@@ -132,5 +132,5 @@ We recommend picking a single option for this rule that works best for your proj
 ## Related To
 
 - [`no-import-type-side-effects`](./no-import-type-side-effects.mdx)
-- [`import/consistent-type-specifier-style`](https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/consistent-type-specifier-style.mdx)
+- [`import/consistent-type-specifier-style`](https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/consistent-type-specifier-style.md)
 - [`import/no-duplicates` with `{"prefer-inline": true}`](https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-duplicates.md#inline-type-imports)
diff --git a/packages/eslint-plugin/docs/rules/no-duplicate-imports.mdx b/packages/eslint-plugin/docs/rules/no-duplicate-imports.mdx
@@ -1,6 +1,6 @@
 :::danger Deprecated
 
-This rule has been deprecated in favour of the [`import/no-duplicates`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/docs/rules/no-duplicates.mdx) rule.
+This rule has been deprecated in favour of the [`import/no-duplicates`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/docs/rules/no-duplicates.md) rule.
 
 :::
 
diff --git a/packages/eslint-plugin/docs/rules/no-floating-promises.mdx b/packages/eslint-plugin/docs/rules/no-floating-promises.mdx
@@ -22,8 +22,8 @@ Valid ways of handling a Promise-valued statement include:
 
 This rule also reports when an Array containing Promises is created and not properly handled. The main way to resolve this is by using one of the Promise concurrency methods to create a single Promise, then handling that according to the procedure above. These methods include:
 
-- `Promise.all()`,
-- `Promise.allSettled()`,
+- `Promise.all()`
+- `Promise.allSettled()`
 - `Promise.any()`
 - `Promise.race()`
 
diff --git a/packages/eslint-plugin/docs/rules/no-import-type-side-effects.mdx b/packages/eslint-plugin/docs/rules/no-import-type-side-effects.mdx
@@ -76,5 +76,5 @@ If you're not using TypeScript 5.0's `verbatimModuleSyntax` option and your proj
 ## Related To
 
 - [`consistent-type-imports`](./consistent-type-imports.mdx)
-- [`import/consistent-type-specifier-style`](https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/consistent-type-specifier-style.mdx)
+- [`import/consistent-type-specifier-style`](https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/consistent-type-specifier-style.md)
 - [`import/no-duplicates` with `{"prefer-inline": true}`](https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-duplicates.md#inline-type-imports)
diff --git a/packages/eslint-plugin/docs/rules/no-unnecessary-boolean-literal-compare.mdx b/packages/eslint-plugin/docs/rules/no-unnecessary-boolean-literal-compare.mdx
@@ -114,11 +114,11 @@ if (someNullCondition !== false) {
 
 ```ts option='{ "allowComparingNullableBooleansToFalse": false }'
 declare const someUndefinedCondition: boolean | undefined;
-if (someUndefinedCondition ?? true) {
+if (!(someUndefinedCondition ?? true)) {
 }
 
 declare const someNullCondition: boolean | null;
-if (!(someNullCondition ?? true)) {
+if (someNullCondition ?? true) {
 }
 ```
 
@@ -127,16 +127,16 @@ if (!(someNullCondition ?? true)) {
 
 ## Fixer
 
-|            Comparison             | Fixer Output                    | Notes                                                                               |
-| :-------------------------------: | ------------------------------- | ----------------------------------------------------------------------------------- |
-|       `booleanVar === true`       | `booleanVar`                    |                                                                                     |
-|       `booleanVar !== true`       | `!booleanVar`                   |                                                                                     |
-|      `booleanVar === false`       | `!booleanVar`                   |                                                                                     |
-|      `booleanVar !== false`       | `booleanVar`                    |                                                                                     |
-|   `nullableBooleanVar === true`   | `nullableBooleanVar`            | Only checked/fixed if the `allowComparingNullableBooleansToTrue` option is `false`  |
-|   `nullableBooleanVar !== true`   | `!nullableBooleanVar`           | Only checked/fixed if the `allowComparingNullableBooleansToTrue` option is `false`  |
-| `!(nullableBooleanVar === false)` | `nullableBooleanVar ?? true`    | Only checked/fixed if the `allowComparingNullableBooleansToFalse` option is `false` |
-| `!(nullableBooleanVar !== false)` | `!(nullableBooleanVar ?? true)` | Only checked/fixed if the `allowComparingNullableBooleansToFalse` option is `false` |
+|           Comparison           | Fixer Output                    | Notes                                                                               |
+| :----------------------------: | ------------------------------- | ----------------------------------------------------------------------------------- |
+|     `booleanVar === true`      | `booleanVar`                    |                                                                                     |
+|     `booleanVar !== true`      | `!booleanVar`                   |                                                                                     |
+|     `booleanVar === false`     | `!booleanVar`                   |                                                                                     |
+|     `booleanVar !== false`     | `booleanVar`                    |                                                                                     |
+| `nullableBooleanVar === true`  | `nullableBooleanVar`            | Only checked/fixed if the `allowComparingNullableBooleansToTrue` option is `false`  |
+| `nullableBooleanVar !== true`  | `!nullableBooleanVar`           | Only checked/fixed if the `allowComparingNullableBooleansToTrue` option is `false`  |
+| `nullableBooleanVar === false` | `!(nullableBooleanVar ?? true)` | Only checked/fixed if the `allowComparingNullableBooleansToFalse` option is `false` |
+| `nullableBooleanVar !== false` | `nullableBooleanVar ?? true`    | Only checked/fixed if the `allowComparingNullableBooleansToFalse` option is `false` |
 
 ## When Not To Use It
 
diff --git a/packages/eslint-plugin/docs/rules/unbound-method.mdx b/packages/eslint-plugin/docs/rules/unbound-method.mdx
@@ -16,7 +16,7 @@ Otherwise, passing class methods around as values can remove type safety by fail
 This rule reports when a class method is referenced in an unbound manner.
 
 :::note Tip
-If you're working with `jest`, you can use [`eslint-plugin-jest`'s version of this rule](https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/unbound-method.mdx) to lint your test files, which knows when it's ok to pass an unbound method to `expect` calls.
+If you're working with `jest`, you can use [`eslint-plugin-jest`'s version of this rule](https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/unbound-method.md) to lint your test files, which knows when it's ok to pass an unbound method to `expect` calls.
 :::
 
 ## Examples
diff --git a/packages/eslint-plugin/tests/docs-eslint-output-snapshots/no-unnecessary-boolean-literal-compare.shot b/packages/eslint-plugin/tests/docs-eslint-output-snapshots/no-unnecessary-boolean-literal-compare.shot
diff --git a/packages/eslint-plugin/tests/docs.test.ts b/packages/eslint-plugin/tests/docs.test.ts
@@ -473,7 +473,7 @@ describe('Validating rule metadata', () => {
     describe(ruleName, () => {
       it('`name` field in rule must match the filename', () => {
         // validate if rule name is same as url
-        // there is no way to access this field but its used only in generation of docs url
+        // there is no way to access this field but it's used only in generation of docs url
         expect(rule.meta.docs?.url).toBe(
           `https://typescript-eslint.io/rules/${ruleName}`,
         );
diff --git a/packages/typescript-estree/src/create-program/createProjectProgram.ts b/packages/typescript-estree/src/create-program/createProjectProgram.ts
@@ -47,7 +47,9 @@ function createProjectProgram(
     parseSettings.filePath,
     parseSettings.tsconfigRootDir,
   );
-  const relativeProjects = parseSettings.projects.map(describeProjectFilePath);
+  const relativeProjects = Array.from(parseSettings.projects.values()).map(
+    describeProjectFilePath,
+  );
   const describedPrograms =
     relativeProjects.length === 1
       ? relativeProjects[0]
@@ -92,7 +94,7 @@ function createProjectProgram(
 
   if (!hasMatchedAnError) {
     const [describedInclusions, describedSpecifiers] =
-      parseSettings.projects.length === 1
+      parseSettings.projects.size === 1
         ? ['that TSConfig does not', 'that TSConfig']
         : ['none of those TSConfigs', 'one of those TSConfigs'];
     errorLines.push(
diff --git a/packages/typescript-estree/src/create-program/getWatchProgramsForProjects.ts b/packages/typescript-estree/src/create-program/getWatchProgramsForProjects.ts
@@ -151,7 +151,7 @@ function getWatchProgramsForProjects(
     );
   }
 
-  const currentProjectsFromSettings = new Set(parseSettings.projects);
+  const currentProjectsFromSettings = new Map(parseSettings.projects);
 
   /*
    * before we go into the process of attempting to find and update every program
@@ -198,13 +198,13 @@ function getWatchProgramsForProjects(
    * - the file is new/renamed, and the program hasn't been updated.
    */
   for (const tsconfigPath of parseSettings.projects) {
-    const existingWatch = knownWatchProgramMap.get(tsconfigPath);
+    const existingWatch = knownWatchProgramMap.get(tsconfigPath[0]);
 
     if (existingWatch) {
       const updatedProgram = maybeInvalidateProgram(
         existingWatch,
         filePath,
-        tsconfigPath,
+        tsconfigPath[0],
       );
       if (!updatedProgram) {
         continue;
@@ -215,7 +215,7 @@ function getWatchProgramsForProjects(
 
       // cache and check the file list
       const fileList = updateCachedFileList(
-        tsconfigPath,
+        tsconfigPath[0],
         updatedProgram,
         parseSettings,
       );
@@ -229,15 +229,19 @@ function getWatchProgramsForProjects(
       continue;
     }
 
-    const programWatch = createWatchProgram(tsconfigPath, parseSettings);
-    knownWatchProgramMap.set(tsconfigPath, programWatch);
+    const programWatch = createWatchProgram(tsconfigPath[1], parseSettings);
+    knownWatchProgramMap.set(tsconfigPath[0], programWatch);
 
     const program = programWatch.getProgram().getProgram();
     // sets parent pointers in source files
     program.getTypeChecker();
 
     // cache and check the file list
-    const fileList = updateCachedFileList(tsconfigPath, program, parseSettings);
+    const fileList = updateCachedFileList(
+      tsconfigPath[0],
+      program,
+      parseSettings,
+    );
     if (fileList.has(filePath)) {
       log('Found program for file. %s', filePath);
       // we can return early because we know this program contains the file
diff --git a/packages/typescript-estree/src/parseSettings/createParseSettings.ts b/packages/typescript-estree/src/parseSettings/createParseSettings.ts
@@ -113,7 +113,7 @@ export function createParseSettings(
     programs: Array.isArray(tsestreeOptions.programs)
       ? tsestreeOptions.programs
       : null,
-    projects: [],
+    projects: new Map(),
     range: tsestreeOptions.range === true,
     singleRun,
     suppressDeprecatedPropertyWarnings:
@@ -172,7 +172,7 @@ export function createParseSettings(
   // So in this specific case we default to 'none' if no value was provided
   if (
     tsestreeOptions.jsDocParsingMode == null &&
-    parseSettings.projects.length === 0 &&
+    parseSettings.projects.size === 0 &&
     parseSettings.programs == null &&
     parseSettings.EXPERIMENTAL_projectService == null
   ) {
diff --git a/packages/typescript-estree/src/parseSettings/index.ts b/packages/typescript-estree/src/parseSettings/index.ts
@@ -121,7 +121,7 @@ export interface MutableParseSettings {
   /**
    * Normalized paths to provided project paths.
    */
-  projects: readonly CanonicalPath[];
+  projects: ReadonlyMap<CanonicalPath, string>;
 
   /**
    * Whether to add the `range` property to AST nodes.
diff --git a/packages/typescript-estree/src/parseSettings/resolveProjectList.ts b/packages/typescript-estree/src/parseSettings/resolveProjectList.ts
@@ -18,8 +18,10 @@ const log = debug(
   'typescript-eslint:typescript-estree:parser:parseSettings:resolveProjectList',
 );
 
-let RESOLUTION_CACHE: ExpiringCache<string, readonly CanonicalPath[]> | null =
-  null;
+let RESOLUTION_CACHE: ExpiringCache<
+  string,
+  ReadonlyMap<CanonicalPath, string>
+> | null = null;
 
 export function clearGlobCache(): void {
   RESOLUTION_CACHE?.clear();
@@ -36,7 +38,7 @@ export function resolveProjectList(
     singleRun: boolean;
     tsconfigRootDir: string;
   }>,
-): readonly CanonicalPath[] {
+): ReadonlyMap<CanonicalPath, string> {
   const sanitizedProjects: string[] = [];
 
   // Normalize and sanitize the project paths
@@ -49,7 +51,7 @@ export function resolveProjectList(
   }
 
   if (sanitizedProjects.length === 0) {
-    return [];
+    return new Map();
   }
 
   const projectFolderIgnoreList = (
@@ -91,7 +93,7 @@ export function resolveProjectList(
   const nonGlobProjects = sanitizedProjects.filter(project => !isGlob(project));
   const globProjects = sanitizedProjects.filter(project => isGlob(project));
 
-  const uniqueCanonicalProjectPaths = new Set(
+  const uniqueCanonicalProjectPaths = new Map(
     nonGlobProjects
       .concat(
         globProjects.length === 0
@@ -101,21 +103,21 @@ export function resolveProjectList(
               dot: true,
             }),
       )
-      .map(project =>
+      .map(project => [
         getCanonicalFileName(
           ensureAbsolutePath(project, options.tsconfigRootDir),
         ),
-      ),
+        ensureAbsolutePath(project, options.tsconfigRootDir),
+      ]),
   );
 
   log(
     'parserOptions.project (excluding ignored) matched projects: %s',
     uniqueCanonicalProjectPaths,
   );
 
-  const returnValue = Array.from(uniqueCanonicalProjectPaths);
-  RESOLUTION_CACHE.set(cacheKey, returnValue);
-  return returnValue;
+  RESOLUTION_CACHE.set(cacheKey, uniqueCanonicalProjectPaths);
+  return uniqueCanonicalProjectPaths;
 }
 
 function getHash({
diff --git a/packages/typescript-estree/src/parser.ts b/packages/typescript-estree/src/parser.ts
@@ -173,21 +173,21 @@ function parseAndGenerateServices<T extends TSESTreeOptions = TSESTreeOptions>(
   if (
     parseSettings.singleRun &&
     !parseSettings.programs &&
-    parseSettings.projects.length > 0
+    parseSettings.projects.size > 0
   ) {
     parseSettings.programs = {
       *[Symbol.iterator](): Iterator<ts.Program> {
         for (const configFile of parseSettings.projects) {
-          const existingProgram = existingPrograms.get(configFile);
+          const existingProgram = existingPrograms.get(configFile[0]);
           if (existingProgram) {
             yield existingProgram;
           } else {
             log(
               'Detected single-run/CLI usage, creating Program once ahead of time for project: %s',
               configFile,
             );
-            const newProgram = createProgramFromConfigFile(configFile);
-            existingPrograms.set(configFile, newProgram);
+            const newProgram = createProgramFromConfigFile(configFile[1]);
+            existingPrograms.set(configFile[0], newProgram);
             yield newProgram;
           }
         }
@@ -199,7 +199,7 @@ function parseAndGenerateServices<T extends TSESTreeOptions = TSESTreeOptions>(
    * Generate a full ts.Program or offer provided instances in order to be able to provide parser services, such as type-checking
    */
   const hasFullTypeInformation =
-    parseSettings.programs != null || parseSettings.projects.length > 0;
+    parseSettings.programs != null || parseSettings.projects.size > 0;
 
   if (
     typeof tsestreeOptions.errorOnTypeScriptSyntacticAndSemanticIssues ===
diff --git a/packages/typescript-estree/tests/lib/inferSingleRun.test.ts b/packages/typescript-estree/tests/lib/inferSingleRun.test.ts
@@ -51,25 +51,63 @@ describe('inferSingleRun', () => {
     expect(actual).toBe(true);
   });
 
-  it('returns true when run by the ESLint CLI in npm/yarn', () => {
-    process.argv = ['node', path.normalize('node_modules/.bin/eslint')];
+  it.each(['project', 'programs'])(
+    'returns false when given %j is null',
+    key => {
+      const actual = inferSingleRun({ [key]: null });
+
+      expect(actual).toBe(false);
+    },
+  );
+
+  it.each([
+    ['true', true],
+    ['false', false],
+  ])('return %s when given TSESTREE_SINGLE_RUN is "%s"', (run, expected) => {
+    process.env.TSESTREE_SINGLE_RUN = run;
+
+    const actual = inferSingleRun({
+      programs: null,
+      project: './tsconfig.json',
+    });
+
+    expect(actual).toBe(expected);
+  });
 
-    const actual = inferSingleRun({ project: true });
+  it.each(['node_modules/.bin/eslint', 'node_modules/eslint/bin/eslint.js'])(
+    'returns true when singleRun is inferred from process.argv',
+    pathName => {
+      process.argv = ['', path.normalize(pathName), ''];
 
-    expect(actual).toBe(true);
-  });
+      const actual = inferSingleRun({
+        programs: null,
+        project: './tsconfig.json',
+      });
 
-  it('returns true when run by the ESLint CLI in pnpm', () => {
-    process.argv = [
-      'node',
-      path.normalize('node_modules/eslint/bin/eslint.js'),
-    ];
+      expect(actual).toBe(true);
+    },
+  );
 
-    const actual = inferSingleRun({ project: true });
+  it('returns true when singleRun is inferred from CI=true', () => {
+    process.env.CI = 'true';
+
+    const actual = inferSingleRun({
+      programs: null,
+      project: './tsconfig.json',
+    });
 
     expect(actual).toBe(true);
   });
 
+  it('returns false when there is no way to infer singleRun', () => {
+    const actual = inferSingleRun({
+      programs: null,
+      project: './tsconfig.json',
+    });
+
+    expect(actual).toBe(false);
+  });
+
   it('returns false when none of the known cases are true', () => {
     const actual = inferSingleRun({ project: true });
 
diff --git a/packages/typescript-estree/tests/lib/semanticInfo-singleRun.test.ts b/packages/typescript-estree/tests/lib/semanticInfo-singleRun.test.ts
diff --git a/packages/website/data/sponsors.json b/packages/website/data/sponsors.json
diff --git a/packages/website/src/components/linter/config.ts b/packages/website/src/components/linter/config.ts
