fix(typescript-estree): don't add in-project files to defaultProjectMatchedFiles (typescript-eslint#9097)

Emanuel Hoogeveen · web-flow · commit a124d4f3f488 · 2024-05-15T12:11:50.000-07:00
* fix(typescript-estree): don't add in-project files to defaultProjectMatchedFiles

Only add path to defaultProjectMatchedFiles if opened.configFileName is falsy.

* test(typescript-estree): add additional unit test for project service

Ensure it does not throw for in-project files
diff --git a/packages/typescript-estree/src/useProgramFromProjectService.ts b/packages/typescript-estree/src/useProgramFromProjectService.ts
@@ -83,7 +83,9 @@ export function useProgramFromProjectService(
     return undefined;
   }
 
-  defaultProjectMatchedFiles.add(filePathAbsolute);
+  if (!opened.configFileName) {
+    defaultProjectMatchedFiles.add(filePathAbsolute);
+  }
   if (defaultProjectMatchedFiles.size > maximumDefaultProjectFileMatchCount) {
     throw new Error(
       `Too many files (>${maximumDefaultProjectFileMatchCount}) have matched the default project.${DEFAULT_PROJECT_FILES_ERROR_EXPLANATION}
diff --git a/packages/typescript-estree/tests/lib/useProgramFromProjectService.test.ts b/packages/typescript-estree/tests/lib/useProgramFromProjectService.test.ts
@@ -220,4 +220,29 @@ If you absolutely need more files included, set parserOptions.EXPERIMENTAL_usePr
 
     expect(actual).toBe(program);
   });
+
+  it('returns a created program when hasFullTypeInformation is disabled, the file is in the project service, the service has a matching program, and no out-of-project files are allowed', () => {
+    const { service } = createMockProjectService();
+    const program = { getSourceFile: jest.fn() };
+
+    mockGetProgram.mockReturnValueOnce(program);
+
+    service.openClientFile.mockReturnValueOnce({
+      configFileName: 'tsconfig.json',
+    });
+    mockCreateProjectProgram.mockReturnValueOnce(program);
+
+    const actual = useProgramFromProjectService(
+      createProjectServiceSettings({
+        allowDefaultProjectForFiles: [],
+        maximumDefaultProjectFileMatchCount: 0,
+        service,
+      }),
+      mockParseSettings,
+      false,
+      new Set(),
+    );
+
+    expect(actual).toBe(program);
+  });
 });
