chore: enable prefer-regexp-test (typescript-eslint#9658)

abrahamguo · web-flow · commit a26e3c7056fd · 2024-08-07T18:14:01.000-04:00
prefer-regexp-test
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -322,6 +322,7 @@ export default tseslint.config(
       'jsdoc/informative-docs': 'error',
       'unicorn/no-typeof-undefined': 'error',
       'unicorn/no-useless-spread': 'error',
+      'unicorn/prefer-regexp-test': 'error',
     },
   },
   {
diff --git a/packages/eslint-plugin/src/util/getWrappingFixer.ts b/packages/eslint-plugin/src/util/getWrappingFixer.ts
@@ -67,7 +67,7 @@ export function getWrappingFixer(
     }
 
     // check if we need to insert semicolon
-    if (/^[`([]/.exec(code) && isMissingSemicolonBefore(node, sourceCode)) {
+    if (/^[`([]/.test(code) && isMissingSemicolonBefore(node, sourceCode)) {
       code = `;${code}`;
     }
 
diff --git a/packages/parser/tests/test-utils/test-utils.ts b/packages/parser/tests/test-utils/test-utils.ts
@@ -59,7 +59,7 @@ export function createSnapshotTestBlock(
        * If we are deliberately throwing because of encountering an unknown
        * AST_NODE_TYPE, we rethrow to cause the test to fail
        */
-      if (/Unknown AST_NODE_TYPE/.exec((error as Error).message)) {
+      if ((error as Error).message.includes('Unknown AST_NODE_TYPE')) {
         throw error;
       }
       expect(parse).toThrowErrorMatchingSnapshot();
diff --git a/packages/typescript-estree/tests/test-utils/test-utils.ts b/packages/typescript-estree/tests/test-utils/test-utils.ts
@@ -44,7 +44,7 @@ export function createSnapshotTestBlock(
        * If we are deliberately throwing because of encountering an unknown
        * AST_NODE_TYPE, we rethrow to cause the test to fail
        */
-      if (/Unknown AST_NODE_TYPE/.exec((error as Error).message)) {
+      if ((error as Error).message.includes('Unknown AST_NODE_TYPE')) {
         throw error;
       }
       expect(parse).toThrowErrorMatchingSnapshot();

Original file line number	Diff line number	Diff line change
`@@ -322,6 +322,7 @@ export default tseslint.config(`
`322`	`322`	`'jsdoc/informative-docs': 'error',`
`323`	`323`	`'unicorn/no-typeof-undefined': 'error',`
`324`	`324`	`'unicorn/no-useless-spread': 'error',`
	`325`	`+ 'unicorn/prefer-regexp-test': 'error',`
`325`	`326`	`},`
`326`	`327`	`},`
`327`	`328`	`{`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ export function getWrappingFixer(`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`// check if we need to insert semicolon`
`70`		- if (/^[`([]/.exec(code) && isMissingSemicolonBefore(node, sourceCode)) {
	`70`	+ if (/^[`([]/.test(code) && isMissingSemicolonBefore(node, sourceCode)) {
`71`	`71`	code = `;${code}`;
`72`	`72`	`}`
`73`	`73`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ export function createSnapshotTestBlock(`
`59`	`59`	`* If we are deliberately throwing because of encountering an unknown`
`60`	`60`	`* AST_NODE_TYPE, we rethrow to cause the test to fail`
`61`	`61`	`*/`
`62`		`- if (/Unknown AST_NODE_TYPE/.exec((error as Error).message)) {`
	`62`	`+ if ((error as Error).message.includes('Unknown AST_NODE_TYPE')) {`
`63`	`63`	`throw error;`
`64`	`64`	`}`
`65`	`65`	`expect(parse).toThrowErrorMatchingSnapshot();`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ export function createSnapshotTestBlock(`
`44`	`44`	`* If we are deliberately throwing because of encountering an unknown`
`45`	`45`	`* AST_NODE_TYPE, we rethrow to cause the test to fail`
`46`	`46`	`*/`
`47`		`- if (/Unknown AST_NODE_TYPE/.exec((error as Error).message)) {`
	`47`	`+ if ((error as Error).message.includes('Unknown AST_NODE_TYPE')) {`
`48`	`48`	`throw error;`
`49`	`49`	`}`
`50`	`50`	`expect(parse).toThrowErrorMatchingSnapshot();`