Fix broken parsing of new expressions when allowReserved=="never"

LongTengDao · marijnh · commit e2b8cc087386 · 2019-08-07T19:11:42.000+02:00
diff --git a/acorn/src/expression.js b/acorn/src/expression.js
@@ -272,7 +272,7 @@ pp.parseSubscript = function(base, startPos, startLoc, noCalls, maybeAsyncArrow)
   if (computed || this.eat(tt.dot)) {
     let node = this.startNodeAt(startPos, startLoc)
     node.object = base
-    node.property = computed ? this.parseExpression() : this.parseIdent(true)
+    node.property = computed ? this.parseExpression() : this.parseIdent(this.options.allowReserved !== "never")
     node.computed = !!computed
     if (computed) this.expect(tt.bracketR)
     base = this.finishNode(node, "MemberExpression")
@@ -734,7 +734,7 @@ pp.parsePropertyName = function(prop) {
       prop.computed = false
     }
   }
-  return prop.key = this.type === tt.num || this.type === tt.string ? this.parseExprAtom() : this.parseIdent(true)
+  return prop.key = this.type === tt.num || this.type === tt.string ? this.parseExprAtom() : this.parseIdent(this.options.allowReserved !== "never")
 }
 
 // Initialize empty function node.
@@ -902,7 +902,6 @@ pp.checkUnreserved = function({start, end, name}) {
 
 pp.parseIdent = function(liberal, isBinding) {
   let node = this.startNode()
-  if (liberal && this.options.allowReserved === "never") liberal = false
   if (this.type === tt.name) {
     node.name = this.value
   } else if (this.type.keyword) {
diff --git a/test/tests.js b/test/tests.js
@@ -7,6 +7,33 @@ if (typeof exports != "undefined") {
   var acorn = require("../acorn");
 }
 
+test("new Object", {
+  type: "Program",
+  start: 0,
+  end: 10,
+  body: [
+    {
+      type: "ExpressionStatement",
+      start: 0,
+      end: 10,
+      expression: {
+        type: "NewExpression",
+        start: 0,
+        end: 10,
+        callee: {
+          type: "Identifier",
+          start: 4,
+          end: 10,
+          name: "Object"
+        },
+        arguments: []
+      }
+    }
+  ]
+}, {
+  allowReserved: "never"
+});
+
 test("this\n", {
   type: "Program",
   body: [
