From d14c82c71825ea8d75dafbbe769d05bdd4bc1d78 Mon Sep 17 00:00:00 2001 From: Andrew Gwozdziewycz Date: Tue, 9 May 2023 16:45:46 +0000 Subject: [PATCH] Trim trailing space from discovered Python versions. The setup-python action failed because my .python-version (generated from a recent pyenv) had a trailing newline (not sure if this is a bug in pyenv, but I'll look there next). ``` Installed versions Version 3.11.3 was not found in the local cache Error: The version '3.11.3 ' with architecture 'x64' was not found for Ubuntu 18.04. The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json ``` As you can see, the version was not discovered because the newline didn't match exactly. The way I figure, even if this is user error, stripping trailing space is super easy, and will probably prevent some problems. --- src/setup-python.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/setup-python.ts b/src/setup-python.ts index 69ea9d368..26dc7e92e 100644 --- a/src/setup-python.ts +++ b/src/setup-python.ts @@ -42,7 +42,7 @@ function resolveVersionInput() { `The specified python version file at: ${versionFile} doesn't exist.` ); } - const version = fs.readFileSync(versionFile, 'utf8'); + const version = fs.readFileSync(versionFile, 'utf8').trimEnd(); core.info(`Resolved ${versionFile} as ${version}`); return [version]; } @@ -52,7 +52,7 @@ function resolveVersionInput() { ); versionFile = '.python-version'; if (fs.existsSync(versionFile)) { - const version = fs.readFileSync(versionFile, 'utf8'); + const version = fs.readFileSync(versionFile, 'utf8').trimEnd(); core.info(`Resolved ${versionFile} as ${version}`); return [version]; } pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy