Enable old-style-definition diagnostic on atmel-samd

jepler · jepler · commit 837cfa0d2c75 · 2025-05-26T21:41:59.000+02:00
diff --git a/ports/atmel-samd/Makefile b/ports/atmel-samd/Makefile
@@ -107,7 +107,7 @@ else
   endif
 endif
 
-CFLAGS += $(INC) -Wall -Werror -std=gnu11 -nostdlib -fshort-enums $(BASE_CFLAGS) $(CFLAGS_MOD) $(COPT) -Werror=missing-prototypes
+CFLAGS += $(INC) -Wall -Werror -std=gnu11 -nostdlib -fshort-enums $(BASE_CFLAGS) $(CFLAGS_MOD) $(COPT) -Werror=missing-prototypes -Werror=old-style-definition
 
 ifeq ($(CHIP_FAMILY), samd21)
 CFLAGS += \
diff --git a/ports/atmel-samd/audio_dma.c b/ports/atmel-samd/audio_dma.c
@@ -30,7 +30,7 @@ static audio_dma_t *audio_dma_state[AUDIO_DMA_CHANNEL_COUNT];
 // This cannot be in audio_dma_state because it's volatile.
 static volatile bool audio_dma_pending[AUDIO_DMA_CHANNEL_COUNT];
 
-uint8_t find_sync_event_channel_raise() {
+uint8_t find_sync_event_channel_raise(void) {
     uint8_t event_channel = find_sync_event_channel();
     if (event_channel >= EVSYS_SYNCH_NUM) {
         mp_raise_RuntimeError(MP_ERROR_TEXT("All sync event channels in use"));
diff --git a/ports/atmel-samd/common-hal/_pew/PewPew.c b/ports/atmel-samd/common-hal/_pew/PewPew.c
@@ -38,7 +38,7 @@ void pewpew_interrupt_handler(uint8_t index) {
     tc->COUNT16.INTFLAG.reg = TC_INTFLAG_MC0;
 }
 
-void pew_init() {
+void pew_init(void) {
     pew_obj_t *pew = MP_STATE_VM(pew_singleton);
 
     common_hal_digitalio_digitalinout_switch_to_input(pew->buttons, PULL_UP);
@@ -105,6 +105,6 @@ void pew_reset(void) {
     MP_STATE_VM(pew_singleton) = NULL;
 }
 
-uint16_t pew_get_ticks() {
+uint16_t pew_get_ticks(void) {
     return pewpew_ticks;
 }
diff --git a/ports/atmel-samd/common-hal/analogio/AnalogIn.c b/ports/atmel-samd/common-hal/analogio/AnalogIn.c
@@ -64,7 +64,7 @@ void common_hal_analogio_analogin_deinit(analogio_analogin_obj_t *self) {
     self->pin = NULL;
 }
 
-void analogin_reset() {
+void analogin_reset(void) {
 }
 
 uint16_t common_hal_analogio_analogin_get_value(analogio_analogin_obj_t *self) {
diff --git a/ports/atmel-samd/common-hal/touchio/TouchIn.c b/ports/atmel-samd/common-hal/touchio/TouchIn.c
@@ -91,7 +91,7 @@ void common_hal_touchio_touchin_deinit(touchio_touchin_obj_t *self) {
     self->config.pin = NO_PIN;
 }
 
-void touchin_reset() {
+void touchin_reset(void) {
     Ptc *ptc = ((Ptc *)PTC);
     if (ptc->CTRLA.bit.ENABLE == 1) {
         ptc->CTRLA.bit.ENABLE = 0;

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ void pewpew_interrupt_handler(uint8_t index) {`
`38`	`38`	`tc->COUNT16.INTFLAG.reg = TC_INTFLAG_MC0;`
`39`	`39`	`}`
`40`	`40`
`41`		`-void pew_init() {`
	`41`	`+void pew_init(void) {`
`42`	`42`	`pew_obj_t *pew = MP_STATE_VM(pew_singleton);`
`43`	`43`
`44`	`44`	`common_hal_digitalio_digitalinout_switch_to_input(pew->buttons, PULL_UP);`
`@@ -105,6 +105,6 @@ void pew_reset(void) {`
`105`	`105`	`MP_STATE_VM(pew_singleton) = NULL;`
`106`	`106`	`}`
`107`	`107`
`108`		`-uint16_t pew_get_ticks() {`
	`108`	`+uint16_t pew_get_ticks(void) {`
`109`	`109`	`return pewpew_ticks;`
`110`	`110`	`}`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ void common_hal_analogio_analogin_deinit(analogio_analogin_obj_t *self) {`
`64`	`64`	`self->pin = NULL;`
`65`	`65`	`}`
`66`	`66`
`67`		`-void analogin_reset() {`
	`67`	`+void analogin_reset(void) {`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`uint16_t common_hal_analogio_analogin_get_value(analogio_analogin_obj_t *self) {`
Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ void common_hal_touchio_touchin_deinit(touchio_touchin_obj_t *self) {`
`91`	`91`	`self->config.pin = NO_PIN;`
`92`	`92`	`}`
`93`	`93`
`94`		`-void touchin_reset() {`
	`94`	`+void touchin_reset(void) {`
`95`	`95`	`Ptc ptc = ((Ptc )PTC);`
`96`	`96`	`if (ptc->CTRLA.bit.ENABLE == 1) {`
`97`	`97`	`ptc->CTRLA.bit.ENABLE = 0;`