Fix -Wold-style-definion errors in the raspberypi port

jepler · jepler · commit 971cbaf09041 · 2025-05-24T20:40:38.000+02:00
This mostly means changing `void foo()` to `void foo(void)` at
the function definition site. This was previously only an error
if the declaration site didn't have `(void)`, but the unix
coverage build enables the more strict warning and there's little
difficulty in resolving these diagnostics.

.. other ports can be done too, if desired.
diff --git a/devices/ble_hci/common-hal/_bleio/__init__.c b/devices/ble_hci/common-hal/_bleio/__init__.c
@@ -40,13 +40,13 @@ bool vm_used_ble;
 void common_hal_bleio_init(void) {
 }
 
-void bleio_user_reset() {
+void bleio_user_reset(void) {
     // HCI doesn't support the BLE workflow so just do a full reset.
     bleio_reset();
 }
 
 // Turn off BLE on a reset or reload.
-void bleio_reset() {
+void bleio_reset(void) {
     // Create a UUID object for all CCCD's.
     cccd_uuid.base.type = &bleio_uuid_type;
     common_hal_bleio_uuid_construct(&cccd_uuid, BLE_UUID_CCCD, NULL);
diff --git a/main.c b/main.c
@@ -1180,7 +1180,7 @@ void gc_collect(void) {
 }
 
 // Ports may provide an implementation of this function if it is needed
-MP_WEAK void port_gc_collect() {
+MP_WEAK void port_gc_collect(void) {
 }
 
 size_t gc_get_max_new_split(void) {
diff --git a/ports/raspberrypi/Makefile b/ports/raspberrypi/Makefile
@@ -223,7 +223,7 @@ endif
 
 DISABLE_WARNINGS = -Wno-cast-align
 
-CFLAGS += $(INC) -Wtype-limits -Wall -Werror -std=gnu11 -fshort-enums $(BASE_CFLAGS) $(CFLAGS_MOD) $(COPT) $(DISABLE_WARNINGS) -Werror=missing-prototypes
+CFLAGS += $(INC) -Wtype-limits -Wall -Werror -std=gnu11 -fshort-enums $(BASE_CFLAGS) $(CFLAGS_MOD) $(COPT) $(DISABLE_WARNINGS) -Werror=missing-prototypes -Wold-style-definition
 
 PICO_LDFLAGS = --specs=nosys.specs --specs=nano.specs
 
diff --git a/shared-module/touchio/TouchIn.c b/shared-module/touchio/TouchIn.c
@@ -86,7 +86,7 @@ void common_hal_touchio_touchin_deinit(touchio_touchin_obj_t *self) {
     self->digitalinout = MP_OBJ_NULL;
 }
 
-void touchin_reset() {
+void touchin_reset(void) {
 }
 
 bool common_hal_touchio_touchin_get_value(touchio_touchin_obj_t *self) {
diff --git a/supervisor/shared/background_callback.c b/supervisor/shared/background_callback.c
@@ -58,7 +58,7 @@ inline bool background_callback_pending(void) {
 
 static int background_prevention_count;
 
-void PLACE_IN_ITCM(background_callback_run_all)() {
+void PLACE_IN_ITCM(background_callback_run_all)(void) {
     port_background_task();
     if (!background_callback_pending()) {
         return;
@@ -89,21 +89,21 @@ void PLACE_IN_ITCM(background_callback_run_all)() {
     CALLBACK_CRITICAL_END;
 }
 
-void background_callback_prevent() {
+void background_callback_prevent(void) {
     CALLBACK_CRITICAL_BEGIN;
     ++background_prevention_count;
     CALLBACK_CRITICAL_END;
 }
 
-void background_callback_allow() {
+void background_callback_allow(void) {
     CALLBACK_CRITICAL_BEGIN;
     --background_prevention_count;
     CALLBACK_CRITICAL_END;
 }
 
 
 // Filter out queued callbacks if they are allocated on the heap.
-void background_callback_reset() {
+void background_callback_reset(void) {
     background_callback_t *new_head = NULL;
     background_callback_t **previous_next = &new_head;
     background_callback_t *new_tail = NULL;
diff --git a/supervisor/shared/reload.c b/supervisor/shared/reload.c
@@ -35,16 +35,16 @@ void reload_initiate(supervisor_run_reason_t run_reason) {
     port_wake_main_task();
 }
 
-void autoreload_reset() {
+void autoreload_reset(void) {
     last_autoreload_trigger = 0;
 }
 
-void autoreload_enable() {
+void autoreload_enable(void) {
     autoreload_enabled = true;
     last_autoreload_trigger = 0;
 }
 
-void autoreload_disable() {
+void autoreload_disable(void) {
     autoreload_enabled = false;
 }
 
@@ -56,11 +56,11 @@ void autoreload_resume(uint32_t suspend_reason_mask) {
     autoreload_suspended &= ~suspend_reason_mask;
 }
 
-inline bool autoreload_is_enabled() {
+inline bool autoreload_is_enabled(void) {
     return autoreload_enabled;
 }
 
-void autoreload_trigger() {
+void autoreload_trigger(void) {
     if (!autoreload_enabled || autoreload_suspended != 0) {
         return;
     }
@@ -78,7 +78,7 @@ void autoreload_trigger() {
     }
 }
 
-bool autoreload_ready() {
+bool autoreload_ready(void) {
     if (last_autoreload_trigger == 0 || autoreload_suspended != 0) {
         return false;
     }
diff --git a/supervisor/shared/status_leds.c b/supervisor/shared/status_leds.c
@@ -112,7 +112,7 @@ static uint32_t current_status_color = 0;
 #endif
 
 static bool status_led_init_in_progress = false;
-void status_led_init() {
+void status_led_init(void) {
     if (status_led_init_in_progress) {
         // Avoid recursion.
         return;
@@ -186,7 +186,7 @@ void status_led_init() {
     status_led_init_in_progress = false;
 }
 
-void status_led_deinit() {
+void status_led_deinit(void) {
     #ifdef MICROPY_HW_NEOPIXEL
     // Make sure the pin stays low for the reset period. The pin reset may pull
     // it up and stop the reset period.
diff --git a/supervisor/shared/tick.c b/supervisor/shared/tick.c
@@ -92,14 +92,14 @@ static uint64_t _get_raw_subticks(void) {
     return (ticks << 5) | subticks;
 }
 
-uint64_t supervisor_ticks_ms64() {
+uint64_t supervisor_ticks_ms64(void) {
     uint64_t result;
     result = port_get_raw_ticks(NULL);
     result = result * 1000 / 1024;
     return result;
 }
 
-uint32_t supervisor_ticks_ms32() {
+uint32_t supervisor_ticks_ms32(void) {
     return supervisor_ticks_ms64();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -40,13 +40,13 @@ bool vm_used_ble;`
`40`	`40`	`void common_hal_bleio_init(void) {`
`41`	`41`	`}`
`42`	`42`
`43`		`-void bleio_user_reset() {`
	`43`	`+void bleio_user_reset(void) {`
`44`	`44`	`// HCI doesn't support the BLE workflow so just do a full reset.`
`45`	`45`	`bleio_reset();`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`// Turn off BLE on a reset or reload.`
`49`		`-void bleio_reset() {`
	`49`	`+void bleio_reset(void) {`
`50`	`50`	`// Create a UUID object for all CCCD's.`
`51`	`51`	`cccd_uuid.base.type = &bleio_uuid_type;`
`52`	`52`	`common_hal_bleio_uuid_construct(&cccd_uuid, BLE_UUID_CCCD, NULL);`
Original file line number	Diff line number	Diff line change
`@@ -1180,7 +1180,7 @@ void gc_collect(void) {`
`1180`	`1180`	`}`
`1181`	`1181`
`1182`	`1182`	`// Ports may provide an implementation of this function if it is needed`
`1183`		`-MP_WEAK void port_gc_collect() {`
	`1183`	`+MP_WEAK void port_gc_collect(void) {`
`1184`	`1184`	`}`
`1185`	`1185`
`1186`	`1186`	`size_t gc_get_max_new_split(void) {`
Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ void common_hal_touchio_touchin_deinit(touchio_touchin_obj_t *self) {`
`86`	`86`	`self->digitalinout = MP_OBJ_NULL;`
`87`	`87`	`}`
`88`	`88`
`89`		`-void touchin_reset() {`
	`89`	`+void touchin_reset(void) {`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`bool common_hal_touchio_touchin_get_value(touchio_touchin_obj_t *self) {`
Original file line number	Diff line number	Diff line change
`@@ -35,16 +35,16 @@ void reload_initiate(supervisor_run_reason_t run_reason) {`
`35`	`35`	`port_wake_main_task();`
`36`	`36`	`}`
`37`	`37`
`38`		`-void autoreload_reset() {`
	`38`	`+void autoreload_reset(void) {`
`39`	`39`	`last_autoreload_trigger = 0;`
`40`	`40`	`}`
`41`	`41`
`42`		`-void autoreload_enable() {`
	`42`	`+void autoreload_enable(void) {`
`43`	`43`	`autoreload_enabled = true;`
`44`	`44`	`last_autoreload_trigger = 0;`
`45`	`45`	`}`
`46`	`46`
`47`		`-void autoreload_disable() {`
	`47`	`+void autoreload_disable(void) {`
`48`	`48`	`autoreload_enabled = false;`
`49`	`49`	`}`
`50`	`50`
`@@ -56,11 +56,11 @@ void autoreload_resume(uint32_t suspend_reason_mask) {`
`56`	`56`	`autoreload_suspended &= ~suspend_reason_mask;`
`57`	`57`	`}`
`58`	`58`
`59`		`-inline bool autoreload_is_enabled() {`
	`59`	`+inline bool autoreload_is_enabled(void) {`
`60`	`60`	`return autoreload_enabled;`
`61`	`61`	`}`
`62`	`62`
`63`		`-void autoreload_trigger() {`
	`63`	`+void autoreload_trigger(void) {`
`64`	`64`	`if (!autoreload_enabled \|\| autoreload_suspended != 0) {`
`65`	`65`	`return;`
`66`	`66`	`}`
`@@ -78,7 +78,7 @@ void autoreload_trigger() {`
`78`	`78`	`}`
`79`	`79`	`}`
`80`	`80`
`81`		`-bool autoreload_ready() {`
	`81`	`+bool autoreload_ready(void) {`
`82`	`82`	`if (last_autoreload_trigger == 0 \|\| autoreload_suspended != 0) {`
`83`	`83`	`return false;`
`84`	`84`	`}`
Original file line number	Diff line number	Diff line change
`@@ -92,14 +92,14 @@ static uint64_t _get_raw_subticks(void) {`
`92`	`92`	`return (ticks << 5) \| subticks;`
`93`	`93`	`}`
`94`	`94`
`95`		`-uint64_t supervisor_ticks_ms64() {`
	`95`	`+uint64_t supervisor_ticks_ms64(void) {`
`96`	`96`	`uint64_t result;`
`97`	`97`	`result = port_get_raw_ticks(NULL);`
`98`	`98`	`result = result * 1000 / 1024;`
`99`	`99`	`return result;`
`100`	`100`	`}`
`101`	`101`
`102`		`-uint32_t supervisor_ticks_ms32() {`
	`102`	`+uint32_t supervisor_ticks_ms32(void) {`
`103`	`103`	`return supervisor_ticks_ms64();`
`104`	`104`	`}`
`105`	`105`