add a test for a bug

aignas · aignas · commit 95535027c06c · 2025-07-07T22:10:30.000+09:00
diff --git a/python/private/pypi/pep508_env.bzl b/python/private/pypi/pep508_env.bzl
@@ -139,7 +139,6 @@ os_name_select_map = {
     _DEFAULT: "posix",
 }
 
-# TODO @aignas 2025-07-07: add a test to ensure that this is tested
 def _get_from_map(m, key):
     if _DEFAULT in m:
         return m.get(key, m[_DEFAULT])
diff --git a/tests/pypi/pep508/evaluate_tests.bzl b/tests/pypi/pep508/evaluate_tests.bzl
@@ -260,6 +260,13 @@ def _evaluate_with_aliases(env):
             "platform_system == 'Darwin' and platform_machine == 'x86_32'": True,
             "platform_system == 'Darwin' and platform_machine == 'x86_64'": False,
         },
+        ("freebsd", "x86_32"): {
+            "platform_system == 'FreeBSD' and platform_machine == 'i386'": True,
+            "platform_system == 'FreeBSD' and platform_machine == 'i686'": True,
+            "platform_system == 'FreeBSD' and platform_machine == 'x86_32'": True,
+            "platform_system == 'FreeBSD' and platform_machine == 'x86_64'": False,
+            "platform_system == 'FreeBSD' and os_name == 'posix'": True,
+        },
     }.items():  # buildifier: @unsorted-dict-items
         for input, want in tests.items():
             _check_evaluate(env, input, want, pep508_env(

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,6 @@ os_name_select_map = {`
`139`	`139`	`_DEFAULT: "posix",`
`140`	`140`	`}`
`141`	`141`
`142`		`-# TODO @aignas 2025-07-07: add a test to ensure that this is tested`
`143`	`142`	`def _get_from_map(m, key):`
`144`	`143`	`if _DEFAULT in m:`
`145`	`144`	`return m.get(key, m[_DEFAULT])`