Handle unhandled promise rejections

64json · 64json · commit 148c3c9991de · 2018-08-09T01:18:56.000+09:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [2.0.3]
+### Fixed
+- Handle unhandled promise rejections
+
 ## [2.0.2]
 ### Fixed
 - Build executer's Docker images only when building tracers libraries
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@algorithm-visualizer/tracer-generator",
-  "version": "2.0.2",
+  "version": "2.0.3",
   "description": "Visualization Libraries for Algorithm Visualizer",
   "scripts": {
     "build": "node ./node_modules/webpack/bin/webpack --bail --progress --config webpack.config.js && chmod +x ./bin/*"
diff --git a/src/common/util.js b/src/common/util.js
@@ -4,7 +4,7 @@ import child_process from 'child_process';
 const execute = (command, cwd, { stdout = process.stdout, stderr = process.stderr } = {}) => new Promise((resolve, reject) => {
   if (!cwd) return reject(new Error('CWD Not Specified'));
   const child = child_process.exec(command, { cwd }, (error, stdout, stderr) => {
-    if (error) return reject(new Error(stderr));
+    if (error) return reject(error.code ? new Error(stderr) : error);
     resolve(stdout);
   });
   if (stdout) child.stdout.pipe(stdout);
@@ -13,4 +13,4 @@ const execute = (command, cwd, { stdout = process.stdout, stderr = process.stder
 
 export {
   execute,
-};
+};
diff --git a/src/executables/build.js b/src/executables/build.js
@@ -3,7 +3,7 @@ import Promise from 'bluebird';
 
 const { LANG } = process.env;
 if (LANG) {
-  languages[LANG].build();
+  languages[LANG].build().catch(() => process.exit(1));
 } else {
-  Promise.each(Object.values(languages), language => language.build());
+  Promise.each(Object.values(languages), language => language.build()).catch(() => process.exit(1));
 }
diff --git a/src/executables/compile.js b/src/executables/compile.js
@@ -1,4 +1,4 @@
 import * as languages from '/languages';
 
 const { LANG, TEMP_PATH } = process.env;
-languages[LANG].compile(TEMP_PATH);
+languages[LANG].compile(TEMP_PATH).catch(() => process.exit(1));
diff --git a/src/executables/release.js b/src/executables/release.js
@@ -1,15 +1,17 @@
-import child_process from 'child_process';
 import ghRelease from 'gh-release';
+import Promise from 'bluebird';
 import { version } from '/package.json';
+import { execute } from '/common/util';
 
 const { GITHUB_TOKEN } = process.env;
-ghRelease({
-  owner: 'algorithm-visualizer',
-  repo: 'tracers',
-  auth: { token: GITHUB_TOKEN },
-}, err => {
-  if (err) throw err;
-  const docsProcess = child_process.exec([
+const release = Promise.promisify(ghRelease);
+
+release({ owner: 'algorithm-visualizer', repo: 'tracers', auth: { token: GITHUB_TOKEN } })
+  .catch(error => {
+    console.error(error);
+    throw error;
+  })
+  .then(() => execute([
     'rm -rf tracers.wiki',
     'git clone git@github.com:algorithm-visualizer/tracers.wiki.git',
     'rm tracers.wiki/*',
@@ -20,8 +22,5 @@ ghRelease({
     'git push origin master',
     'cd ..',
     'rm -rf tracers.wiki',
-  ].join(' && '), { cwd: __dirname });
-  docsProcess.stdout.pipe(process.stdout);
-  docsProcess.stderr.pipe(process.stderr);
-  docsProcess.on('exit', process.exit);
-});
+  ].join(' && '), __dirname))
+  .catch(() => process.exit(1));
diff --git a/src/executables/run.js b/src/executables/run.js
@@ -1,4 +1,4 @@
 import * as languages from '/languages';
 
 const { LANG, TEMP_PATH } = process.env;
-languages[LANG].run(TEMP_PATH);
+languages[LANG].run(TEMP_PATH).catch(() => process.exit(1));

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@algorithm-visualizer/tracer-generator",`
`3`		`- "version": "2.0.2",`
	`3`	`+ "version": "2.0.3",`
`4`	`4`	`"description": "Visualization Libraries for Algorithm Visualizer",`
`5`	`5`	`"scripts": {`
`6`	`6`	`"build": "node ./node_modules/webpack/bin/webpack --bail --progress --config webpack.config.js && chmod +x ./bin/*"`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ import Promise from 'bluebird';`
`3`	`3`
`4`	`4`	`const { LANG } = process.env;`
`5`	`5`	`if (LANG) {`
`6`		`- languages[LANG].build();`
	`6`	`+ languages[LANG].build().catch(() => process.exit(1));`
`7`	`7`	`} else {`
`8`		`- Promise.each(Object.values(languages), language => language.build());`
	`8`	`+ Promise.each(Object.values(languages), language => language.build()).catch(() => process.exit(1));`
`9`	`9`	`}`