fix(ngAria): don't add roles to native elements

m-amr · m-amr · commit 2f981b7a06a3 · 2016-03-30T19:36:07.000+02:00
don't add roles to textarea, button, select, summary, details, a and input Closes #14076 BREAKING CHANGE: albeit a small one that shouldn't affect a11y
diff --git a/src/ngAria/aria.js b/src/ngAria/aria.js
@@ -221,8 +221,8 @@ ngAriaModule.directive('ngShow', ['$aria', function($aria) {
   function shouldAttachRole(role, elem) {
     // if element does not have role attribute
     // AND element type is equal to role (if custom element has a type equaling shape) <-- remove?
-    // AND element is not INPUT
-    return !elem.attr('role') && (elem.attr('type') === role) && (elem[0].nodeName !== 'INPUT');
+    // AND element is not in nodeBlackList
+    return !elem.attr('role') && (elem.attr('type') === role) && !isNodeOneOf(elem, nodeBlackList);
   }
 
   function getShape(attr, elem) {
diff --git a/test/ngAria/ariaSpec.js b/test/ngAria/ariaSpec.js
@@ -272,6 +272,18 @@ describe('$aria', function() {
       compileElement('<input type="range" ng-model="val"></div>');
       expect(element.attr('role')).toBe(undefined);
     });
+
+    they('should not add role to native $prop controls', {
+      select: '<select type="checkbox" ng-model="val"></select>',
+      textarea: '<textarea type="checkbox" ng-model="val"></textarea>',
+      button: '<button ng-click="doClick()"></button>',
+      summary: '<summary ng-click="doClick()"></summary>',
+      details: '<details ng-click="doClick()"></details>',
+      a: '<a ng-click="doClick()"></a>'
+    }, function(tmpl) {
+      var element = $compile(tmpl)(scope);
+      expect(element.attr('role')).toBeUndefined();
+    });
   });
 
   describe('aria-checked when disabled', function() {
