Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 4267ad6

Browse files
committed
chore(ci): use default project from config when deploying to Firebase
Previously, when deploying `scripts/{code,docs}.angularjs.org-firebase/` to Firebase, we explicitly specified the target projects. Since the project IDs are also specified in the respective `.firebaserc` files, this was unnecessary (and meant we had multiple places to update if the IDs changed). This commit simplifies the process by automatically targeting the default projects (as configured in the `.firebaserc` files) when deploying to Firebase in CI.
1 parent 66ada20 commit 4267ad6

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

.circleci/config.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,8 @@ jobs:
383383
# Do not use `yarn firebase` as that causes the Firebase CLI to look for `firebase.json`
384384
# in the root directory, even if run from inside `scripts/code.angularjs.org-firebase/`.
385385
firebase=$(yarn bin)/firebase
386-
$firebase deploy --message "Commit:\ $CI_COMMIT" --non-interactive --project "code-angularjs-org-338b8" --token "$FIREBASE_TOKEN"
386+
$firebase use
387+
$firebase deploy --message "Commit:\ $CI_COMMIT" --non-interactive --token "$FIREBASE_TOKEN"
387388
388389
# The `deploy-docs` job should only run when all of these conditions are true for the build:
389390
# - It is for the `angular/angular.js` repository (not a fork).
@@ -412,7 +413,8 @@ jobs:
412413
# Do not use `yarn firebase` as that causes the Firebase CLI to look for `firebase.json`
413414
# in the root directory, even if run from inside `scripts/docs.angularjs.org-firebase/`.
414415
firebase=$(yarn bin)/firebase
415-
$firebase deploy --message "Commit:\ $CI_COMMIT" --non-interactive --project "docs-angularjs-org-9p2" --token "$FIREBASE_TOKEN"
416+
$firebase use
417+
$firebase deploy --message "Commit:\ $CI_COMMIT" --non-interactive --token "$FIREBASE_TOKEN"
416418
417419
workflows:
418420
version: 2

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy