fix($compile): handle boolean attributes in @ bindings

jannic · jannic · commit 4311afcdb33d · 2016-04-05T17:52:48.000+02:00
Commit db5e0ff handles initial values of boolean attributes. The same change needs to be applied inside the attrs.$observe() call.
diff --git a/src/ng/compile.js b/src/ng/compile.js
@@ -3120,7 +3120,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
               destination[scopeName] = attrs[attrName] = void 0;
             }
             attrs.$observe(attrName, function(value) {
-              if (isString(value)) {
+              if (isString(value) || isBoolean(value)) {
                 var oldValue = destination[scopeName];
                 recordChanges(scopeName, value, oldValue);
                 destination[scopeName] = value;

Original file line number	Diff line number	Diff line change
`@@ -3120,7 +3120,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {`
`3120`	`3120`	`destination[scopeName] = attrs[attrName] = void 0;`
`3121`	`3121`	`}`
`3122`	`3122`	`attrs.$observe(attrName, function(value) {`
`3123`		`- if (isString(value)) {`
	`3123`	`+ if (isString(value) \|\| isBoolean(value)) {`
`3124`	`3124`	`var oldValue = destination[scopeName];`
`3125`	`3125`	`recordChanges(scopeName, value, oldValue);`
`3126`	`3126`	`destination[scopeName] = value;`