fix(ngAria): don't add roles to native elements

m-amr · m-amr · commit fc6e7266f628 · 2016-02-28T01:59:09.000+02:00
don't add roles to (textarea, button, select, summary, details, a, input) fix #14076
diff --git a/src/ngAria/aria.js b/src/ngAria/aria.js
@@ -221,8 +221,8 @@ ngAriaModule.directive('ngShow', ['$aria', function($aria) {
   function shouldAttachRole(role, elem) {
     // if element does not have role attribute
     // AND element type is equal to role (if custom element has a type equaling shape) <-- remove?
-    // AND element is not INPUT
-    return !elem.attr('role') && (elem.attr('type') === role) && (elem[0].nodeName !== 'INPUT');
+    // AND element is not in nodeBlackList
+    return !elem.attr('role') && (elem.attr('type') === role) && !isNodeOneOf(elem, nodeBlackList);
   }
 
   function getShape(attr, elem) {
diff --git a/test/ngAria/ariaSpec.js b/test/ngAria/ariaSpec.js
@@ -272,6 +272,37 @@ describe('$aria', function() {
       compileElement('<input type="range" ng-model="val"></div>');
       expect(element.attr('role')).toBe(undefined);
     });
+
+    it('should not add a role to a native select', function() {
+      compileElement('<select type="checkbox" ng-model="val"></select>');
+      expect(element.attr('role')).toBe(undefined);
+    });
+
+    it('should not add a role to a native textarea element', function() {
+      compileElement('<textarea type="checkbox" ng-model="val"></textarea>');
+      expect(element.attr('role')).toBe(undefined);
+    });
+
+    it('should not add a role to a native button element', function() {
+      compileElement('<button ng-click="doClick()"></button>');
+      expect(element.attr('role')).toBe(undefined);
+    });
+
+    it('should not add a role to a native summary element', function() {
+      compileElement('<summary ng-click="doClick()"></summary>');
+      expect(element.attr('role')).toBe(undefined);
+    });
+
+    it('should not add a role to a native details element', function() {
+      compileElement('<details ng-click="doClick()"></details>');
+      expect(element.attr('role')).toBe(undefined);
+    });
+
+    it('should not add a role to a native a element', function() {
+      compileElement('<a ng-click="doClick()"></a>');
+      expect(element.attr('role')).toBe(undefined);
+    });
+
   });
 
   describe('aria-checked when disabled', function() {
