Fix timeout on empty socket in HTTPClient

annda · annda · commit 5ca11da0f6f4 · 2021-04-14T11:11:38.000+02:00
feof() sometimes hangs if nothing has beeen written yet see php/php-src#3729
diff --git a/inc/HTTP/HTTPClient.php b/inc/HTTP/HTTPClient.php
@@ -577,7 +577,11 @@ protected function sendData($socket, $data, $message) {
             $time_used = $this->time() - $this->start;
             if($time_used > $this->timeout)
                 throw new HTTPClientException(sprintf('Timeout while sending %s (%.3fs)',$message, $time_used), -100);
-            if(feof($socket))
+
+            // feof() sometimes hangs until first byte is written
+            // probably fixed around PHP 7.2 in https://github.com/php/php-src/pull/3729
+            if ($written > 0 && feof($socket))
+            if (feof($socket))
                 throw new HTTPClientException("Socket disconnected while writing $message");
 
             // select parameters
