test: gather all output before going on with tests

cmaglie · cmaglie · commit 1621776cc725 · 2020-06-19T11:49:52.000+01:00
Wait for consumer thread to collect all output before returning from
command line run. This patch avoid a race condition (the test output
is checked before all the output is actually collected).
diff --git a/app/test/processing/app/CommandLineTest.java b/app/test/processing/app/CommandLineTest.java
@@ -86,14 +86,16 @@ public static void findBuildPaths() throws Exception {
     System.out.println("found arduino: " + arduinoPath);
   }
 
-  private void consume(InputStream s, OutputStream out) {
-    new Thread(() -> {
+  private Thread consume(InputStream s, OutputStream out) {
+    Thread t = new Thread(() -> {
       try {
         IOUtils.copy(s, out);
       } catch (IOException e) {
         e.printStackTrace();
       }
-    }).start();
+    });
+    t.start();
+    return t;
   }
 
   public Process runArduino(OutputStream output, boolean success, File wd, String[] extraArgs) throws IOException, InterruptedException {
@@ -107,9 +109,11 @@ public Process runArduino(OutputStream output, boolean success, File wd, String[
     System.out.println("Running: " + String.join(" ", args));
 
     Process pr = rt.exec(args.toArray(new String[0]), null, wd);
-    consume(pr.getInputStream(), output);
-    consume(pr.getErrorStream(), System.err);
+    Thread outThread = consume(pr.getInputStream(), output);
+    Thread errThread = consume(pr.getErrorStream(), System.err);
     pr.waitFor();
+    outThread.join(5000);
+    errThread.join(5000);
     if (success)
       assertEquals(0, pr.exitValue());
     return pr;
