Merge pull request #144 from facchinm/no_forced_namespace

facchinm · web-flow · commit 4baf42c8fea0 · 2021-04-06T15:47:12.000+02:00
Remove forceful "using namespace arduino" from headers
diff --git a/api/Print.h b/api/Print.h
@@ -93,4 +93,4 @@ class Print
 };
 
 }
-using namespace arduino;
+using arduino::Print;
diff --git a/api/String.h b/api/String.h
@@ -255,5 +255,8 @@ class StringSumHelper : public String
 
 } // namespace arduino
 
+using arduino::__FlashStringHelper;
+using arduino::String;
+
 #endif  // __cplusplus
 #endif  // __ARDUINO_STRINGS__
diff --git a/api/Udp.h b/api/Udp.h
@@ -87,6 +87,4 @@ class UDP : public Stream {
   uint8_t* rawIPAddress(IPAddress& addr) { return addr.raw_address(); };
 };
 
-}
-
-using namespace arduino;
+}
diff --git a/test/src/Stream/test_parseFloat.cpp b/test/src/Stream/test_parseFloat.cpp
@@ -12,6 +12,8 @@
 
 #include <float.h>
 
+using namespace arduino;
+
 /**************************************************************************************
  * TEST CODE
  **************************************************************************************/
diff --git a/test/src/Stream/test_parseInt.cpp b/test/src/Stream/test_parseInt.cpp
@@ -14,6 +14,8 @@
  * TEST CODE
  **************************************************************************************/
 
+using namespace arduino;
+
 TEST_CASE ("Testing parseInt(LookaheadMode lookahead = SKIP_ALL, char ignore = NO_IGNORE_CHAR)", "[Stream-parseInt-01]")
 {
   StreamMock mock;

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,8 @@`
`14`	`14`	`* TEST CODE`
`15`	`15`	`**************************************************************************************/`
`16`	`16`
	`17`	`+using namespace arduino;`
	`18`	`+`
`17`	`19`	`TEST_CASE ("Testing parseInt(LookaheadMode lookahead = SKIP_ALL, char ignore = NO_IGNORE_CHAR)", "[Stream-parseInt-01]")`
`18`	`20`	`{`
`19`	`21`	`StreamMock mock;`