Skip to content

Commit 5e2880e

Browse files
authored
Fix bitWrite with parenthesis
Current version does not wrap arguments in "()", so works incorrectly when used like this: ``` bitWrite(var, bit, cond?1:0); ```
1 parent 173e8ea commit 5e2880e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

api/Common.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ typedef void (*voidFuncPtrParam)(void*);
6565
#define bitSet(value, bit) ((value) |= (1UL << (bit)))
6666
#define bitClear(value, bit) ((value) &= ~(1UL << (bit)))
6767
#define bitToggle(value, bit) ((value) ^= (1UL << (bit)))
68-
#define bitWrite(value, bit, bitvalue) (bitvalue ? bitSet(value, bit) : bitClear(value, bit))
68+
#define bitWrite(value, bit, bitvalue) ((bitvalue) ? bitSet((value), (bit)) : bitClear((value), (bit)))
6969

7070
#ifndef bit
7171
#define bit(b) (1UL << (b))

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy