Simplify String::concat(char)

matthijskooijman · matthijskooijman · commit 81a2d51b212c · 2021-01-25T10:04:20.000+01:00
Now concat(const char*, unsigned int) no longer requires a
nul-terminated string, we can simplify the concat(char) method to just
pass the address of the single character instead of having to create
buffer with nul-termination.
diff --git a/api/String.cpp b/api/String.cpp
@@ -297,10 +297,7 @@ unsigned char String::concat(const char *cstr)
 
 unsigned char String::concat(char c)
 {
-	char buf[2];
-	buf[0] = c;
-	buf[1] = 0;
-	return concat(buf, 1);
+	return concat(&c, 1);
 }
 
 unsigned char String::concat(unsigned char num)

Original file line number	Diff line number	Diff line change
`@@ -297,10 +297,7 @@ unsigned char String::concat(const char *cstr)`
`297`	`297`
`298`	`298`	`unsigned char String::concat(char c)`
`299`	`299`	`{`
`300`		`- char buf[2];`
`301`		`- buf[0] = c;`
`302`		`- buf[1] = 0;`
`303`		`- return concat(buf, 1);`
	`300`	`+ return concat(&c, 1);`
`304`	`301`	`}`
`305`	`302`
`306`	`303`	`unsigned char String::concat(unsigned char num)`