Added missing virtual destructors

andreagilardoni · andreagilardoni · commit c37cff539914 · 2023-11-21T14:11:32.000+01:00
diff --git a/api/Print.h b/api/Print.h
@@ -42,6 +42,8 @@ class Print
     void setWriteError(int err = 1) { write_error = err; }
   public:
     Print() : write_error(0) {}
+    virtual ~Print() {}
+
 
     int getWriteError() { return write_error; }
     void clearWriteError() { setWriteError(0); }
diff --git a/api/Printable.h b/api/Printable.h
@@ -33,6 +33,7 @@ class Print;
 class Printable
 {
   public:
+    virtual ~Printable() {}
     virtual size_t printTo(Print& p) const = 0;
 };
 
diff --git a/api/String.h b/api/String.h
@@ -81,7 +81,7 @@ class String
 	explicit String(unsigned long, unsigned char base=10);
 	explicit String(float, unsigned char decimalPlaces=2);
 	explicit String(double, unsigned char decimalPlaces=2);
-	~String(void);
+	virtual ~String(void);
 
 	// memory management
 	// return true on success, false on failure (in which case, the string

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@ class Print;`
`33`	`33`	`class Printable`
`34`	`34`	`{`
`35`	`35`	`public:`
	`36`	`+ virtual ~Printable() {}`
`36`	`37`	`virtual size_t printTo(Print& p) const = 0;`
`37`	`38`	`};`
`38`	`39`