Skip to content

Commit 7537ac1

Browse files
cmagliecmaglie
committed
Removed useless constants in main.go
1 parent 0662887 commit 7537ac1

File tree

1 file changed

+36
-92
lines changed

1 file changed

+36
-92
lines changed

‎main.go

Lines changed: 36 additions & 92 deletions
Original file line numberDiff line numberDiff line change
@@ -57,39 +57,6 @@ import (
5757

5858
const VERSION = "1.6.1"
5959

60-
const FLAG_ACTION_PREPROCESS = "preprocess"
61-
const FLAG_ACTION_DUMP_PREFS = "dump-prefs"
62-
const FLAG_ACTION_CODE_COMPLETE_AT = "code-complete-at"
63-
const FLAG_BUILD_OPTIONS_FILE = "build-options-file"
64-
const FLAG_HARDWARE = "hardware"
65-
const FLAG_TOOLS = "tools"
66-
const FLAG_BUILT_IN_LIBRARIES = "built-in-libraries"
67-
const FLAG_LIBRARIES = "libraries"
68-
const FLAG_PREFS = "prefs"
69-
const FLAG_FQBN = "fqbn"
70-
const FLAG_IDE_VERSION = "ide-version"
71-
const FLAG_CORE_API_VERSION = "core-api-version"
72-
const FLAG_BUILD_PATH = "build-path"
73-
const FLAG_BUILD_CACHE = "build-cache"
74-
const FLAG_VERBOSE = "verbose"
75-
const FLAG_QUIET = "quiet"
76-
const FLAG_DEBUG_LEVEL = "debug-level"
77-
const FLAG_WARNINGS = "warnings"
78-
const FLAG_WARNINGS_NONE = "none"
79-
const FLAG_WARNINGS_DEFAULT = "default"
80-
const FLAG_WARNINGS_MORE = "more"
81-
const FLAG_WARNINGS_ALL = "all"
82-
const FLAG_LOGGER = "logger"
83-
const FLAG_LOGGER_HUMAN = "human"
84-
const FLAG_LOGGER_HUMANTAGS = "humantags"
85-
const FLAG_LOGGER_MACHINE = "machine"
86-
const FLAG_VERSION = "version"
87-
const FLAG_DAEMON = "daemon"
88-
const FLAG_VID_PID = "vid-pid"
89-
const FLAG_JOBS = "jobs"
90-
const FLAG_TRACE = "trace"
91-
const FLAG_EXPERIMENTAL = "experimental"
92-
9360
type foldersFlag []string
9461

9562
func (h *foldersFlag) String() string {
@@ -114,61 +81,38 @@ func (h *propertiesFlag) Set(value string) error {
11481
return nil
11582
}
11683

117-
var preprocessFlag *bool
118-
var dumpPrefsFlag *bool
119-
var codeCompleteAtFlag *string
120-
var buildOptionsFileFlag *string
121-
var hardwareFoldersFlag foldersFlag
122-
var toolsFoldersFlag foldersFlag
123-
var librariesBuiltInFoldersFlag foldersFlag
124-
var librariesFoldersFlag foldersFlag
125-
var customBuildPropertiesFlag propertiesFlag
126-
var fqbnFlag *string
127-
var coreAPIVersionFlag *string
128-
var ideVersionFlag *string
129-
var buildPathFlag *string
130-
var buildCachePathFlag *string
131-
var verboseFlag *bool
132-
var quietFlag *bool
133-
var debugLevelFlag *int
134-
var warningsLevelFlag *string
135-
var loggerFlag *string
136-
var versionFlag *bool
137-
var daemonFlag *bool
138-
var vidPidFlag *string
139-
var jobsFlag *int
140-
var traceFlag *bool
141-
var experimentalFeatures *bool
142-
143-
func init() {
144-
preprocessFlag = flag.Bool(FLAG_ACTION_PREPROCESS, false, "preprocess the given sketch")
145-
dumpPrefsFlag = flag.Bool(FLAG_ACTION_DUMP_PREFS, false, "dumps build properties used when compiling")
146-
codeCompleteAtFlag = flag.String(FLAG_ACTION_CODE_COMPLETE_AT, "", "output code completions for sketch at a specific location. Location format is \"file:line:col\"")
147-
buildOptionsFileFlag = flag.String(FLAG_BUILD_OPTIONS_FILE, "", "Instead of specifying --"+FLAG_HARDWARE+", --"+FLAG_TOOLS+" etc every time, you can load all such options from a file")
148-
flag.Var(&hardwareFoldersFlag, FLAG_HARDWARE, "Specify a 'hardware' folder. Can be added multiple times for specifying multiple 'hardware' folders")
149-
flag.Var(&toolsFoldersFlag, FLAG_TOOLS, "Specify a 'tools' folder. Can be added multiple times for specifying multiple 'tools' folders")
150-
flag.Var(&librariesBuiltInFoldersFlag, FLAG_BUILT_IN_LIBRARIES, "Specify a built-in 'libraries' folder. These are low priority libraries. Can be added multiple times for specifying multiple built-in 'libraries' folders")
151-
flag.Var(&librariesFoldersFlag, FLAG_LIBRARIES, "Specify a 'libraries' folder. Can be added multiple times for specifying multiple 'libraries' folders")
152-
flag.Var(&customBuildPropertiesFlag, FLAG_PREFS, "Specify a custom preference. Can be added multiple times for specifying multiple custom preferences")
153-
fqbnFlag = flag.String(FLAG_FQBN, "", "fully qualified board name")
154-
coreAPIVersionFlag = flag.String(FLAG_CORE_API_VERSION, "10600", "version of core APIs (used to populate ARDUINO #define)")
155-
ideVersionFlag = flag.String(FLAG_IDE_VERSION, "10600", "[deprecated] use '"+FLAG_CORE_API_VERSION+"' instead")
156-
buildPathFlag = flag.String(FLAG_BUILD_PATH, "", "build path")
157-
buildCachePathFlag = flag.String(FLAG_BUILD_CACHE, "", "builds of 'core.a' are saved into this folder to be cached and reused")
158-
verboseFlag = flag.Bool(FLAG_VERBOSE, false, "if 'true' prints lots of stuff")
159-
quietFlag = flag.Bool(FLAG_QUIET, false, "if 'true' doesn't print any warnings or progress or whatever")
160-
debugLevelFlag = flag.Int(FLAG_DEBUG_LEVEL, builder.DEFAULT_DEBUG_LEVEL, "Turns on debugging messages. The higher, the chattier")
161-
warningsLevelFlag = flag.String(FLAG_WARNINGS, "", "Sets warnings level. Available values are '"+FLAG_WARNINGS_NONE+"', '"+FLAG_WARNINGS_DEFAULT+"', '"+FLAG_WARNINGS_MORE+"' and '"+FLAG_WARNINGS_ALL+"'")
162-
loggerFlag = flag.String(FLAG_LOGGER, FLAG_LOGGER_HUMAN, "Sets type of logger. Available values are '"+FLAG_LOGGER_HUMAN+"', '"+FLAG_LOGGER_HUMANTAGS+"', '"+FLAG_LOGGER_MACHINE+"'")
163-
versionFlag = flag.Bool(FLAG_VERSION, false, "prints version and exits")
164-
daemonFlag = flag.Bool(FLAG_DAEMON, false, "daemonizes and serves its functions via rpc")
165-
vidPidFlag = flag.String(FLAG_VID_PID, "", "specify to use vid/pid specific build properties, as defined in boards.txt")
166-
jobsFlag = flag.Int(FLAG_JOBS, 0, "specify how many concurrent gcc processes should run at the same time. Defaults to the number of available cores on the running machine")
167-
traceFlag = flag.Bool(FLAG_TRACE, false, "traces the whole process lifecycle")
168-
experimentalFeatures = flag.Bool(FLAG_EXPERIMENTAL, false, "enables experimental features")
169-
}
170-
17184
func main() {
85+
var hardwareFoldersFlag foldersFlag
86+
var toolsFoldersFlag foldersFlag
87+
var librariesBuiltInFoldersFlag foldersFlag
88+
var librariesFoldersFlag foldersFlag
89+
var customBuildPropertiesFlag propertiesFlag
90+
91+
preprocessFlag := flag.Bool("preprocess", false, "preprocess the given sketch")
92+
dumpPrefsFlag := flag.Bool("dump-prefs", false, "dumps build properties used when compiling")
93+
codeCompleteAtFlag := flag.String("code-complete-at", "", "output code completions for sketch at a specific location. Location format is \"file:line:col\"")
94+
buildOptionsFileFlag := flag.String("build-options-file", "", "Instead of specifying --hardware, --tools etc every time, you can load all such options from a file")
95+
flag.Var(&hardwareFoldersFlag, "hardware", "Specify a 'hardware' folder. Can be added multiple times for specifying multiple 'hardware' folders")
96+
flag.Var(&toolsFoldersFlag, "tools", "Specify a 'tools' folder. Can be added multiple times for specifying multiple 'tools' folders")
97+
flag.Var(&librariesBuiltInFoldersFlag, "built-in-libraries", "Specify a built-in 'libraries' folder. These are low priority libraries. Can be added multiple times for specifying multiple built-in 'libraries' folders")
98+
flag.Var(&librariesFoldersFlag, "libraries", "Specify a 'libraries' folder. Can be added multiple times for specifying multiple 'libraries' folders")
99+
flag.Var(&customBuildPropertiesFlag, "prefs", "Specify a custom preference. Can be added multiple times for specifying multiple custom preferences")
100+
fqbnFlag := flag.String("fqbn", "", "fully qualified board name")
101+
coreAPIVersionFlag := flag.String("core-api-version", "10600", "version of core APIs (used to populate ARDUINO #define)")
102+
ideVersionFlag := flag.String("ide-version", "10600", "[deprecated] use 'core-api-version' instead")
103+
buildPathFlag := flag.String("build-path", "", "build path")
104+
buildCachePathFlag := flag.String("build-cache", "", "builds of 'core.a' are saved into this folder to be cached and reused")
105+
verboseFlag := flag.Bool("verbose", false, "if 'true' prints lots of stuff")
106+
quietFlag := flag.Bool("quiet", false, "if 'true' doesn't print any warnings or progress or whatever")
107+
debugLevelFlag := flag.Int("debug-level", builder.DEFAULT_DEBUG_LEVEL, "Turns on debugging messages. The higher, the chattier")
108+
warningsLevelFlag := flag.String("warnings", "", "Sets warnings level. Available values are 'none', 'default', 'more' and 'all'")
109+
loggerFlag := flag.String("logger", "human", "Sets type of logger. Available values are 'human', 'humantags', 'machine'")
110+
versionFlag := flag.Bool("version", false, "prints version and exits")
111+
daemonFlag := flag.Bool("daemon", false, "daemonizes and serves its functions via rpc")
112+
vidPidFlag := flag.String("vid-pid", "", "specify to use vid/pid specific build properties, as defined in boards.txt")
113+
jobsFlag := flag.Int("jobs", 0, "specify how many concurrent gcc processes should run at the same time. Defaults to the number of available cores on the running machine")
114+
traceFlag := flag.Bool("trace", false, "traces the whole process lifecycle")
115+
experimentalFeatures := flag.Bool("experimental", false, "enables experimental features")
172116
// Not used anymore, kept only because the Arduino IDE still provides this flag
173117
flag.Bool("compile", true, "[deprecated] this is now the default action")
174118

@@ -247,7 +191,7 @@ func main() {
247191
ctx.HardwareDirs = paths.NewPathList(hardwareFolders...)
248192
}
249193
if len(ctx.HardwareDirs) == 0 {
250-
printErrorMessageAndFlagUsage(errors.New("Parameter '" + FLAG_HARDWARE + "' is mandatory"))
194+
printErrorMessageAndFlagUsage(errors.New("Parameter 'hardware' is mandatory"))
251195
}
252196

253197
// FLAG_TOOLS
@@ -257,7 +201,7 @@ func main() {
257201
ctx.BuiltInToolsDirs = paths.NewPathList(toolsFolders...)
258202
}
259203
if len(ctx.BuiltInToolsDirs) == 0 {
260-
printErrorMessageAndFlagUsage(errors.New("Parameter '" + FLAG_TOOLS + "' is mandatory"))
204+
printErrorMessageAndFlagUsage(errors.New("Parameter 'tools' is mandatory"))
261205
}
262206

263207
// FLAG_LIBRARIES
@@ -292,7 +236,7 @@ func main() {
292236
}
293237
}
294238
if ctx.FQBN == nil {
295-
printErrorMessageAndFlagUsage(errors.New("Parameter '" + FLAG_FQBN + "' is mandatory"))
239+
printErrorMessageAndFlagUsage(errors.New("Parameter 'fqbn' is mandatory"))
296240
}
297241

298242
// FLAG_BUILD_PATH
@@ -372,10 +316,10 @@ func main() {
372316

373317
if *quietFlag {
374318
ctx.SetLogger(i18n.NoopLogger{})
375-
} else if *loggerFlag == FLAG_LOGGER_MACHINE {
319+
} else if *loggerFlag == "machine" {
376320
ctx.SetLogger(i18n.MachineLogger{})
377321
ctx.Progress.PrintEnabled = true
378-
} else if *loggerFlag == FLAG_LOGGER_HUMANTAGS {
322+
} else if *loggerFlag == "humantags" {
379323
ctx.SetLogger(i18n.HumanTagsLogger{})
380324
} else {
381325
ctx.SetLogger(i18n.HumanLogger{})

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy