Code review fixes

silvanocerza · per1234 · silvanocerza · commit 52f32bf9ab4d · 2021-08-26T17:36:39.000+02:00
Co-authored-by: per1234 &lt;accounts@perglass.com&gt;
diff --git a/cli/config/validate.go b/cli/config/validate.go
@@ -35,7 +35,7 @@ var validMap = map[string]reflect.Kind{
 	"metrics.enabled":               reflect.Bool,
 	"network.proxy":                 reflect.String,
 	"network.user_agent_ext":        reflect.String,
-	"updater.disable_notification":  reflect.Bool,
+	"updater.enable_notification":   reflect.Bool,
 }
 
 func typeOf(key string) (reflect.Kind, error) {
diff --git a/cli/updater/updater.go b/cli/updater/updater.go
@@ -33,7 +33,7 @@ import (
 var tr = i18n.Tr
 
 // CheckForUpdate returns the latest available version if greater than
-// the one running and it makes sense to check for an udpate, nil in all other cases
+// the one running and it makes sense to check for an update, nil in all other cases
 func CheckForUpdate(currentVersion *semver.Version) *semver.Version {
 	if !shouldCheckForUpdate(currentVersion) {
 		return nil
@@ -71,7 +71,7 @@ func checkForUpdate(currentVersion *semver.Version) *semver.Version {
 // NotifyNewVersionIsAvailable prints information about the new latestVersion
 func NotifyNewVersionIsAvailable(latestVersion string) {
 	feedback.Errorf("\n\n%s %s → %s\n%s",
-		ansi.Color(tr("A new release of arduino-cli is available:"), "yellow"),
+		ansi.Color(tr("A new release of Arduino CLI is available:"), "yellow"),
 		ansi.Color(globals.VersionInfo.VersionString, "cyan"),
 		ansi.Color(latestVersion, "cyan"),
 		ansi.Color("https://arduino.github.io/arduino-cli/latest/installation/#latest-packages", "yellow"))
@@ -85,8 +85,8 @@ func shouldCheckForUpdate(currentVersion *semver.Version) bool {
 		return false
 	}
 
-	if configuration.Settings.GetBool("updater.disable_notification") {
-		// Don't check if the user disable the notification
+	if !configuration.Settings.GetBool("updater.enable_notification") {
+		// Don't check if the user disabled the notification
 		return false
 	}
 
diff --git a/configuration/defaults.go b/configuration/defaults.go
@@ -50,7 +50,7 @@ func SetDefaults(settings *viper.Viper) {
 	settings.SetDefault("metrics.addr", ":9090")
 
 	// updater settings
-	settings.SetDefault("updater.disable_notification", false)
+	settings.SetDefault("updater.enable_notification", true)
 
 	// Bind env vars
 	settings.SetEnvPrefix("ARDUINO")
diff --git a/docs/configuration.md b/docs/configuration.md
@@ -25,7 +25,7 @@
   - `always_export_binaries` - set to `true` to make [`arduino-cli compile`][arduino-cli compile] always save binaries
     to the sketch folder. This is the equivalent of using the [`--export-binaries`][arduino-cli compile options] flag.
 - `updater` - configuration options related to Arduino CLI updates
-  - `disable_notification` - set to `true` to disable notifications of new Arduino CLI releases, defaults to `false`
+  - `enable_notification` - set to `false` to disable notifications of new Arduino CLI releases, defaults to `true`
 
 ## Configuration methods
 
diff --git a/docs/installation.md b/docs/installation.md
@@ -41,7 +41,8 @@ curl -fsSL https://raw.githubusercontent.com/arduino/arduino-cli/master/install.
 ```
 
 The Arduino CLI verifies every 24 hours if there are new releases, if you don't like this behaviour you can disable it
-by setting the `updater.disable_notification` config or the env var `ARDUINO_UPDATER_DISABLE_NOTIFICATION` to `true`.
+by setting the [`updater.enable_notification` config](configuration.md#configuration-keys) or the
+[env var `ARDUINO_UPDATER_ENABLE_NOTIFICATION`](configuration.md#environment-variables) to `false`.
 
 ### Download
 

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ var validMap = map[string]reflect.Kind{`
`35`	`35`	`"metrics.enabled": reflect.Bool,`
`36`	`36`	`"network.proxy": reflect.String,`
`37`	`37`	`"network.user_agent_ext": reflect.String,`
`38`		`- "updater.disable_notification": reflect.Bool,`
	`38`	`+ "updater.enable_notification": reflect.Bool,`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`func typeOf(key string) (reflect.Kind, error) {`