Fixed locales (translations) not being detected with default config

cmaglie · cmaglie · commit 9c3ddd16b603 · 2024-10-07T18:32:12.000+02:00
diff --git a/internal/cli/configuration/defaults.go b/internal/cli/configuration/defaults.go
@@ -73,7 +73,7 @@ func SetDefaults(settings *Settings) {
 	setKeyTypeSchema("network.user_agent_ext", "")
 
 	// locale
-	setDefaultValueAndKeyTypeSchema("locale", "en")
+	setKeyTypeSchema("locale", "")
 }
 
 // InjectEnvVars change settings based on the environment variables values
diff --git a/internal/integrationtest/config/config_test.go b/internal/integrationtest/config/config_test.go
@@ -931,3 +931,16 @@ func TestConfigViaEnvVars(t *testing.T) {
 	require.NoError(t, err)
 	require.Equal(t, "20\n\n", string(out))
 }
+
+func TestI18N(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	out, _, err := cli.RunWithCustomEnv(map[string]string{"LANG": "it"})
+	require.NoError(t, err)
+	require.Contains(t, string(out), "Comandi disponibili")
+
+	out, _, err = cli.RunWithCustomEnv(map[string]string{"LANG": "en"})
+	require.NoError(t, err)
+	require.Contains(t, string(out), "Available Commands")
+}

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ func SetDefaults(settings *Settings) {`
`73`	`73`	`setKeyTypeSchema("network.user_agent_ext", "")`
`74`	`74`
`75`	`75`	`// locale`
`76`		`- setDefaultValueAndKeyTypeSchema("locale", "en")`
	`76`	`+ setKeyTypeSchema("locale", "")`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`// InjectEnvVars change settings based on the environment variables values`