Merge pull request #108 from arduino/feature/alert-unsaved

murilopolese · web-flow · commit 54524d1b9a8b · 2024-04-15T17:28:26.000+02:00
Alert user before closing tab with unsaved changes
diff --git a/ui/arduino/store.js b/ui/arduino/store.js
@@ -48,6 +48,10 @@ async function store(state, emitter) {
     parentFolder: null, // Null parent folder means not saved?
     source: 'disk'
   })
+  newFile.editor.onChange = function() {
+    newFile.hasChanges = true
+    emitter.emit('render')
+  }
   state.openFiles.push(newFile)
   state.editingFile = newFile.id
 
@@ -351,6 +355,7 @@ async function store(state, emitter) {
       log('error', e)
     }
 
+    openFile.hasChanges = false
     state.isSaving = false
     state.savingProgress = 0
     emitter.emit('refresh-files')
@@ -365,6 +370,11 @@ async function store(state, emitter) {
   })
   emitter.on('close-tab', (id) => {
     log('close-tab', id)
+    const currentTab = state.openFiles.find(f => f.id === id)
+    if (currentTab.hasChanges && currentTab.parentFolder !== null) {
+      let response = confirm("Your file has unsaved changes. Are you sure you want to proceed?")
+      if (!response) return false
+    }
     state.openFiles = state.openFiles.filter(f => f.id !== id)
     // state.editingFile = null
 
@@ -375,6 +385,10 @@ async function store(state, emitter) {
         source: 'disk',
         parentFolder: null
       })
+      newFile.editor.onChange = function() {
+        newFile.hasChanges = true
+        emitter.emit('render')
+      }
       state.openFiles.push(newFile)
       state.editingFile = newFile.id
     }
@@ -995,6 +1009,7 @@ async function store(state, emitter) {
       }
     }
 
+    openFile.hasChanges = false
     state.renamingTab = null
     state.isSaving = false
     state.savingProgress = 0
@@ -1037,43 +1052,49 @@ async function store(state, emitter) {
     let files = []
     for (let i in state.selectedFiles) {
       let selectedFile = state.selectedFiles[i]
+      let openFile = null
       if (selectedFile.type == 'folder') {
         // Don't open folders
         continue
       }
-      if (selectedFile.source === 'board') {
+      if (selectedFile.source == 'board') {
         const fileContent = await serial.loadFile(
           serial.getFullPath(
             '/',
             state.boardNavigationPath,
             selectedFile.fileName
           )
         )
-        files.push(
-          createFile({
-            parentFolder: state.boardNavigationPath,
-            fileName: selectedFile.fileName,
-            source: selectedFile.source,
-            content: fileContent
-          })
-        )
-      } else {
+        openFile = createFile({
+          parentFolder: state.boardNavigationPath,
+          fileName: selectedFile.fileName,
+          source: selectedFile.source,
+          content: fileContent
+        })
+        openFile.editor.onChange = function() {
+          openFile.hasChanges = true
+          emitter.emit('render')
+        }
+      } else if (selectedFile.source == 'disk') {
         const fileContent = await disk.loadFile(
           disk.getFullPath(
             state.diskNavigationRoot,
             state.diskNavigationPath,
             selectedFile.fileName
           )
         )
-        files.push(
-          createFile({
-            parentFolder: state.diskNavigationPath,
-            fileName: selectedFile.fileName,
-            source: selectedFile.source,
-            content: fileContent
-          })
-        )
+        openFile = createFile({
+          parentFolder: state.diskNavigationPath,
+          fileName: selectedFile.fileName,
+          source: selectedFile.source,
+          content: fileContent
+        })
+        openFile.editor.onChange = function() {
+          openFile.hasChanges = true
+          emitter.emit('render')
+        }
       }
+      files.push(openFile)
     }
 
     files = files.filter((f) => { // find files to open
@@ -1280,11 +1301,17 @@ async function store(state, emitter) {
     emitter.emit('render')
   })
 
-  function createFile({ source, parentFolder, fileName, content = newFileContent }) {
+  function createFile(args) {
+    const {
+      source,
+      parentFolder,
+      fileName,
+      content = newFileContent,
+      hasChanges = false
+    } = args
     const id = generateHash()
     const editor = state.cache(CodeMirrorEditor, `editor_${id}`)
     editor.content = content
-    const hasChanges = false
     return {
       id,
       source,
@@ -1300,6 +1327,7 @@ async function store(state, emitter) {
       fileName: generateFileName(),
       parentFolder,
       source,
+      hasChanges: true
     })
   }
 }
diff --git a/ui/arduino/views/components/elements/editor.js b/ui/arduino/views/components/elements/editor.js
@@ -7,11 +7,11 @@ class CodeMirrorEditor extends Component {
 
   load(el) {
     const onCodeChange = (update) => {
-      this.content = update.state.doc.toString()
       // console.log('code change', this.content)
+      this.content = update.state.doc.toString()
+      this.onChange()
     }
     this.editor = createEditor(this.content, el, onCodeChange)
-
   }
 
   createElement(content) {
@@ -22,4 +22,8 @@ class CodeMirrorEditor extends Component {
   update() {
     return false
   }
+
+  onChange() {
+    return false
+  }
 }
diff --git a/ui/arduino/views/components/elements/tab.js b/ui/arduino/views/components/elements/tab.js
@@ -8,7 +8,8 @@ function Tab(args) {
     onFinishRenaming = () => false,
     disabled = false,
     active = false,
-    renaming = false
+    renaming = false,
+    hasChanges = false
   } = args
 
   if (active) {
@@ -41,7 +42,9 @@ function Tab(args) {
       return html`
         <div class="tab active" tabindex="0">
           <img class="icon" src="media/${icon}" />
-          <div class="text" ondblclick=${onStartRenaming}>${text}</div>
+          <div class="text" ondblclick=${onStartRenaming}>
+            ${hasChanges ? ' *' : ''} ${text}
+          </div>
           <div class="options" >
             <button onclick=${onCloseTab}>
               <img class="icon" src="media/close.svg" />
@@ -65,7 +68,9 @@ function Tab(args) {
       onclick=${selectTab}
       >
       <img class="icon" src="media/${icon}" />
-      <div class="text">${text}</div>
+      <div class="text">
+        ${hasChanges ? '*' : ''} ${text}
+      </div>
       <div class="options">
         <button onclick=${onCloseTab}>
           <img class="icon" src="media/close.svg" />
diff --git a/ui/arduino/views/components/tabs.js b/ui/arduino/views/components/tabs.js
@@ -7,6 +7,7 @@ function Tabs(state, emit) {
           icon: file.source === 'board'? 'connect.svg': 'computer.svg',
           active: file.id === state.editingFile,
           renaming: file.id === state.renamingTab,
+          hasChanges: file.hasChanges,
           onSelectTab: () => emit('select-tab', file.id),
           onCloseTab: () => emit('close-tab', file.id),
           onStartRenaming: () => emit('rename-tab', file.id),

Original file line number	Diff line number	Diff line change
`@@ -7,11 +7,11 @@ class CodeMirrorEditor extends Component {`
`7`	`7`
`8`	`8`	`load(el) {`
`9`	`9`	`const onCodeChange = (update) => {`
`10`		`- this.content = update.state.doc.toString()`
`11`	`10`	`// console.log('code change', this.content)`
	`11`	`+ this.content = update.state.doc.toString()`
	`12`	`+ this.onChange()`
`12`	`13`	`}`
`13`	`14`	`this.editor = createEditor(this.content, el, onCodeChange)`
`14`		`-`
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`createElement(content) {`
`@@ -22,4 +22,8 @@ class CodeMirrorEditor extends Component {`
`22`	`22`	`update() {`
`23`	`23`	`return false`
`24`	`24`	`}`
	`25`	`+`
	`26`	`+ onChange() {`
	`27`	`+ return false`
	`28`	`+ }`
`25`	`29`	`}`