Fix the bug that status bar failed to honor the setting (LeetCode-OpenSource#275)

jdneo · web-flow · commit c7273a44f67d · 2019-04-17T09:53:47.000+08:00
diff --git a/src/statusbar/LeetCodeStatusBarItem.ts b/src/statusbar/LeetCodeStatusBarItem.ts
@@ -16,11 +16,10 @@ export class LeetCodeStatusBarItem implements vscode.Disposable {
         switch (status) {
             case UserStatus.SignedIn:
                 this.statusBarItem.text = `LeetCode: ${user}`;
-                this.statusBarItem.show();
                 break;
             case UserStatus.SignedOut:
             default:
-                this.statusBarItem.hide();
+                this.statusBarItem.text = "";
                 break;
         }
     }
diff --git a/src/statusbar/leetCodeStatusBarController.ts b/src/statusbar/leetCodeStatusBarController.ts
@@ -39,7 +39,7 @@ class LeetCodeStatusBarController implements Disposable {
 
     private isStatusBarEnabled(): boolean {
         const configuration: WorkspaceConfiguration = workspace.getConfiguration();
-        return configuration.get<boolean>("leetcode.enableStatusBar", false);
+        return configuration.get<boolean>("leetcode.enableStatusBar", true);
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -16,11 +16,10 @@ export class LeetCodeStatusBarItem implements vscode.Disposable {`
`16`	`16`	`switch (status) {`
`17`	`17`	`case UserStatus.SignedIn:`
`18`	`18`	this.statusBarItem.text = `LeetCode: ${user}`;
`19`		`- this.statusBarItem.show();`
`20`	`19`	`break;`
`21`	`20`	`case UserStatus.SignedOut:`
`22`	`21`	`default:`
`23`		`- this.statusBarItem.hide();`
	`22`	`+ this.statusBarItem.text = "";`
`24`	`23`	`break;`
`25`	`24`	`}`
`26`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ class LeetCodeStatusBarController implements Disposable {`
`39`	`39`
`40`	`40`	`private isStatusBarEnabled(): boolean {`
`41`	`41`	`const configuration: WorkspaceConfiguration = workspace.getConfiguration();`
`42`		`- return configuration.get<boolean>("leetcode.enableStatusBar", false);`
	`42`	`+ return configuration.get<boolean>("leetcode.enableStatusBar", true);`
`43`	`43`	`}`
`44`	`44`	`}`
`45`	`45`