Fixed #90 - allow disabling of invalid watchers

bwoebi · bwoebi · commit 229d2f3e166a · 2016-08-25T22:48:21.000+02:00
diff --git a/src/Loop.php b/src/Loop.php
@@ -237,8 +237,6 @@ public static function enable($watcherId)
      * @param string $watcherId The watcher identifier.
      *
      * @return void
-     *
-     * @throws InvalidWatcherException If the watcher identifier is invalid.
      */
     public static function disable($watcherId)
     {
diff --git a/src/Loop/Driver.php b/src/Loop/Driver.php
@@ -134,13 +134,12 @@ abstract public function onSignal($signo, callable $callback, $data = null);
     abstract public function enable($watcherId);
 
     /**
-     * Disable a watcher. Disabling a watcher MUST NOT invalidate the watcher.
+     * Disable a watcher. Disabling a watcher MUST NOT invalidate the watcher. Calling this function MUST never fail,
+     * even when passed an invalid watcher.
      *
      * @param string $watcherId The watcher identifier.
      *
      * @return void
-     *
-     * @throws InvalidWatcherException If the watcher identifier is invalid.
      */
     abstract public function disable($watcherId);
 

Original file line number	Diff line number	Diff line change
`@@ -237,8 +237,6 @@ public static function enable($watcherId)`
`237`	`237`	`* @param string $watcherId The watcher identifier.`
`238`	`238`	`*`
`239`	`239`	`* @return void`
`240`		`- *`
`241`		`- * @throws InvalidWatcherException If the watcher identifier is invalid.`
`242`	`240`	`*/`
`243`	`241`	`public static function disable($watcherId)`
`244`	`242`	`{`
Original file line number	Diff line number	Diff line change
`@@ -134,13 +134,12 @@ abstract public function onSignal($signo, callable $callback, $data = null);`
`134`	`134`	`abstract public function enable($watcherId);`
`135`	`135`
`136`	`136`	`/**`
`137`		`- * Disable a watcher. Disabling a watcher MUST NOT invalidate the watcher.`
	`137`	`+ * Disable a watcher. Disabling a watcher MUST NOT invalidate the watcher. Calling this function MUST never fail,`
	`138`	`+ * even when passed an invalid watcher.`
`138`	`139`	`*`
`139`	`140`	`* @param string $watcherId The watcher identifier.`
`140`	`141`	`*`
`141`	`142`	`* @return void`
`142`		`- *`
`143`		`- * @throws InvalidWatcherException If the watcher identifier is invalid.`
`144`	`143`	`*/`
`145`	`144`	`abstract public function disable($watcherId);`
`146`	`145`