Adds cookie domain support

brendensoares · brendensoares · commit 0d091bfa3194 · 2015-02-23T22:31:24.000-08:00
diff --git a/revel.go b/revel.go
@@ -66,7 +66,8 @@ var (
 
 	// All cookies dropped by the framework begin with this prefix.
 	CookiePrefix string
-
+	// Cookie domain
+	CookieDomain string
 	// Cookie flags
 	CookieHttpOnly bool
 	CookieSecure   bool
@@ -181,6 +182,7 @@ func Init(mode, importPath, srcPath string) {
 	AppName = Config.StringDefault("app.name", "(not set)")
 	AppRoot = Config.StringDefault("app.root", "")
 	CookiePrefix = Config.StringDefault("cookie.prefix", "REVEL")
+	CookieDomain = Config.StringDefault("cookie.domain", "")
 	CookieHttpOnly = Config.BoolDefault("cookie.httponly", false)
 	CookieSecure = Config.BoolDefault("cookie.secure", false)
 	TemplateDelims = Config.StringDefault("template.delimiters", "")
diff --git a/session.go b/session.go
@@ -85,6 +85,7 @@ func (s Session) Cookie() *http.Cookie {
 	return &http.Cookie{
 		Name:     CookiePrefix + "_SESSION",
 		Value:    Sign(sessionData) + "-" + sessionData,
+		Domain:   CookieDomain,
 		Path:     "/",
 		HttpOnly: CookieHttpOnly,
 		Secure:   CookieSecure,
diff --git a/skeleton/conf/app.conf.template b/skeleton/conf/app.conf.template
@@ -53,6 +53,8 @@ cookie.prefix = REVEL
 # eavesdropping.
 cookie.secure = false
 
+# Limit cookie access to a given domain
+#cookie.domain =
 
 # Define when your session cookie expires. Possible values:
 # "720h"
diff --git a/validation.go b/validation.go
@@ -210,6 +210,7 @@ func ValidationFilter(c *Controller, fc []Filter) {
 		c.SetCookie(&http.Cookie{
 			Name:     CookiePrefix + "_ERRORS",
 			Value:    url.QueryEscape(errorsValue),
+			Domain:   CookieDomain,
 			Path:     "/",
 			HttpOnly: CookieHttpOnly,
 			Secure:   CookieSecure,
@@ -218,6 +219,7 @@ func ValidationFilter(c *Controller, fc []Filter) {
 		c.SetCookie(&http.Cookie{
 			Name:     CookiePrefix + "_ERRORS",
 			MaxAge:   -1,
+			Domain:   CookieDomain,
 			Path:     "/",
 			HttpOnly: CookieHttpOnly,
 			Secure:   CookieSecure,
