fix revel#1095 param map overwrite priority

pedromorgan · pedromorgan · commit 14a29afa345b · 2017-03-05T01:19:32.000Z
diff --git a/params.go b/params.go
@@ -1,4 +1,4 @@
-// Copyright (c) 2012-2016 The Revel Framework Authors, All rights reserved.
+// Copyright (c) 2012-2017 The Revel Framework Authors, All rights reserved.
 // Revel Framework source code and usage is governed by a MIT style
 // license that can be found in the LICENSE file.
 
@@ -97,20 +97,27 @@ func (p *Params) calcValues() url.Values {
 		return p.Form
 	}
 
-	// Copy everything into the same map.
+	// Copy everything into a param map,
+	// order of priority is least to most trusted
 	values := make(url.Values, numParams)
-	for k, v := range p.Fixed {
+
+	// ?query vars first
+	for k, v := range p.Query {
 		values[k] = append(values[k], v...)
 	}
-	for k, v := range p.Query {
+	// form vars overwrite
+	for k, v := range p.Form {
 		values[k] = append(values[k], v...)
 	}
+	// :/path vars overwrite
 	for k, v := range p.Route {
 		values[k] = append(values[k], v...)
 	}
-	for k, v := range p.Form {
+	// fixed vars overwrite
+	for k, v := range p.Fixed {
 		values[k] = append(values[k], v...)
 	}
+
 	return values
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// Copyright (c) 2012-2016 The Revel Framework Authors, All rights reserved.`
	`1`	`+// Copyright (c) 2012-2017 The Revel Framework Authors, All rights reserved.`
`2`	`2`	`// Revel Framework source code and usage is governed by a MIT style`
`3`	`3`	`// license that can be found in the LICENSE file.`
`4`	`4`
`@@ -97,20 +97,27 @@ func (p *Params) calcValues() url.Values {`
`97`	`97`	`return p.Form`
`98`	`98`	`}`
`99`	`99`
`100`		`- // Copy everything into the same map.`
	`100`	`+ // Copy everything into a param map,`
	`101`	`+ // order of priority is least to most trusted`
`101`	`102`	`values := make(url.Values, numParams)`
`102`		`- for k, v := range p.Fixed {`
	`103`	`+`
	`104`	`+ // ?query vars first`
	`105`	`+ for k, v := range p.Query {`
`103`	`106`	`values[k] = append(values[k], v...)`
`104`	`107`	`}`
`105`		`- for k, v := range p.Query {`
	`108`	`+ // form vars overwrite`
	`109`	`+ for k, v := range p.Form {`
`106`	`110`	`values[k] = append(values[k], v...)`
`107`	`111`	`}`
	`112`	`+ // :/path vars overwrite`
`108`	`113`	`for k, v := range p.Route {`
`109`	`114`	`values[k] = append(values[k], v...)`
`110`	`115`	`}`
`111`		`- for k, v := range p.Form {`
	`116`	`+ // fixed vars overwrite`
	`117`	`+ for k, v := range p.Fixed {`
`112`	`118`	`values[k] = append(values[k], v...)`
`113`	`119`	`}`
	`120`	`+`
`114`	`121`	`return values`
`115`	`122`	`}`
`116`	`123`