Merge pull request revel#881 from revel/bug/production-panic-trace-831

brendensoares · brendensoares · commit c025ee65ed99 · 2015-02-23T22:23:44.000-08:00
Only shows debug stack details in DevMode
diff --git a/panic.go b/panic.go
@@ -19,7 +19,8 @@ func PanicFilter(c *Controller, fc []Filter) {
 // It cleans up the stack trace, logs it, and displays an error page.
 func handleInvocationPanic(c *Controller, err interface{}) {
 	error := NewErrorFromPanic(err)
-	if error == nil {
+	if error == nil && DevMode {
+		// Only show the sensitive information in the debug stack trace in development mode, not production
 		ERROR.Print(err, "\n", string(debug.Stack()))
 		c.Response.Out.WriteHeader(500)
 		c.Response.Out.Write(debug.Stack())
