Fix: video filters support and audio filters memory leak

valnoel · valnoel · commit 2e0fde378374 · 2022-04-27T12:59:11.000+02:00
Free video filters data at each process loop, but skip audio filters data frame. Improvement of be100b8 fix
diff --git a/src/AvTranscoder/transcoder/StreamTranscoder.cpp b/src/AvTranscoder/transcoder/StreamTranscoder.cpp
@@ -751,12 +751,6 @@ IOutputStream::EWrappingStatus StreamTranscoder::processTranscode()
             _transformedData->allocateData();
         }
     }
-    else if(_filterGraph->hasFilters())
-    {
-        LOG_DEBUG("Free filtered data") // filled from filter graph sink
-        av_frame_unref(&_filteredData->getAVFrame());
-        _filteredData->freeData();
-    }
 
     // Check decoding status
     bool continueProcess = true;
@@ -811,6 +805,15 @@ IOutputStream::EWrappingStatus StreamTranscoder::processTranscode()
         LOG_DEBUG("Encode")
         _outputEncoder->encodeFrame(*_transformedData, data);
 
+        if(_filterGraph->hasFilters())
+        {
+            LOG_DEBUG("Free filtered data") // filled from filter graph sink
+            if (_filteredData->isVideoFrame()) {
+                // Do not unref filter audio frame, to avoid reallocating it each time
+                av_frame_unref(&_filteredData->getAVFrame());
+            }
+            _filteredData->freeData();
+        }
     }
     else
     {
